-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add equivlences of ECR, SX and SXdg gates to the equivalence library #9913
Conversation
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me (aside from a minor comment on the release ntoe), thanks Shelly. For posterity: the standard equivalence library is tested for consistency automatically in test/python/circuit/test_gate_definitions.py
.
releasenotes/notes/add-ecr-sx-equivalences-5b6fe73ec599d1a4.yaml
Outdated
Show resolved
Hide resolved
releasenotes/notes/add-ecr-sx-equivalences-5b6fe73ec599d1a4.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super, thanks.
…iskit#9913) * add equivlences of ECR, SX and SXdg gates * update circuit in test_cx_bell_to_ecr * add release notes * update release notes following review * minor fix
…iskit#9913) * add equivlences of ECR, SX and SXdg gates * update circuit in test_cx_bell_to_ecr * add release notes * update release notes following review * minor fix
Summary
close #9907
Add equivalences of to the equivalence library:
Details and comments