Fixing BlockCollapser with Clbits #9823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: chriseclectic <[email protected]>
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 4843816267
💛 - Coveralls |
chriseclectic
requested changes
Apr 12, 2023
mtreinish
approved these changes
May 26, 2023
mtreinish
added
stable backport potential
mergify bot
pushed a commit
that referenced
this pull request
May 26, 2023
* Bug fix: collapsing blocks with clbits Co-authored-by: chriseclectic <[email protected]> * release notes * similar fix to DAGDependency * additional fixes to handle classical bits in conditions * fixing lint issue * Fixing handling of conditions over full registers, following review comments --------- Co-authored-by: chriseclectic <[email protected]> (cherry picked from commit 788b89d)
mtreinish
pushed a commit
that referenced
this pull request
May 26, 2023
* Bug fix: collapsing blocks with clbits Co-authored-by: chriseclectic <[email protected]> * release notes * similar fix to DAGDependency * additional fixes to handle classical bits in conditions * fixing lint issue * Fixing handling of conditions over full registers, following review comments --------- Co-authored-by: chriseclectic <[email protected]> (cherry picked from commit 788b89d) Co-authored-by: Alexander Ivrii <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #9814.
I have added @chriseclectic as a co-author: the code for fixing
BlockCollapserandDAGCircuit, as well as testing is mostly his.Details and comments
Classical bits are now treated correctly in
BlockCollapserand inreplace_block_with_op.