-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing BlockCollapser with Clbits #9823
Conversation
Co-authored-by: chriseclectic <[email protected]>
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 4843816267
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added comments to get this to this work with full ClassicalRegister conditionals as well as Clbit conditionals
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, thanks for fixing this.
* Bug fix: collapsing blocks with clbits Co-authored-by: chriseclectic <[email protected]> * release notes * similar fix to DAGDependency * additional fixes to handle classical bits in conditions * fixing lint issue * Fixing handling of conditions over full registers, following review comments --------- Co-authored-by: chriseclectic <[email protected]> (cherry picked from commit 788b89d)
* Bug fix: collapsing blocks with clbits Co-authored-by: chriseclectic <[email protected]> * release notes * similar fix to DAGDependency * additional fixes to handle classical bits in conditions * fixing lint issue * Fixing handling of conditions over full registers, following review comments --------- Co-authored-by: chriseclectic <[email protected]> (cherry picked from commit 788b89d) Co-authored-by: Alexander Ivrii <[email protected]>
Summary
Fixes #9814.
I have added @chriseclectic as a co-author: the code for fixing
BlockCollapser
andDAGCircuit
, as well as testing is mostly his.Details and comments
Classical bits are now treated correctly in
BlockCollapser
and inreplace_block_with_op
.