Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the gates ECR, iSwap, CY, SX, SXdg, DCX to the Clifford class #9623

Merged
merged 13 commits into from
Feb 22, 2023
Merged

Add the gates ECR, iSwap, CY, SX, SXdg, DCX to the Clifford class #9623

merged 13 commits into from
Feb 22, 2023

Conversation

ShellyGarion
Copy link
Member

@ShellyGarion ShellyGarion commented Feb 19, 2023 •
edited
Loading

Summary

Close #9582

Add the following gates to the file clifford_circuits.py and to the equivalence library:

  • ECR
  • iSwap
  • CY
  • SX
  • SXdg
  • DCX

Details and comments

This is also helpful for #9475

@ShellyGarion ShellyGarion added Changelog: New Feature Include in the "Added" section of the changelog mod: quantum info Related to the Quantum Info module (States & Operators) synthesis labels Feb 19, 2023
@ShellyGarion ShellyGarion requested review from a team and ikkoham as code owners February 19, 2023 15:17
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

@ShellyGarion ShellyGarion mentioned this pull request Feb 19, 2023
Merged
@coveralls
Copy link

coveralls commented Feb 19, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4244627651

  • 41 of 41 (100.0%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 85.283%
Files with Coverage Reduction New Missed Lines %
qiskit/extensions/quantum_initializer/squ.py 2 80.0%
Totals Coverage Status
Change from base Build 4244264068: 0.01%
Covered Lines: 67222
Relevant Lines: 78822
💛 - Coveralls

@ShellyGarion ShellyGarion added this to the 0.24.0 milestone Feb 20, 2023
jakelishman
jakelishman reviewed Feb 20, 2023
View reviewed changes
Copy link
Member

@jakelishman jakelishman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's marked as WIP, but don't forget a release note when you're ready for final review.

qiskit/circuit/library/standard_gates/equivalence_library.py Outdated Show resolved Hide resolved
@ShellyGarion ShellyGarion mentioned this pull request Feb 21, 2023
Closed
@ShellyGarion ShellyGarion changed the title [WIP] Add the gates ECR, iSwap, CY, SX, SXdg to the Clifford class [WIP] Add the gates ECR, iSwap, CY, SX, SXdg, DCX to the Clifford class Feb 21, 2023
@ShellyGarion ShellyGarion changed the title [WIP] Add the gates ECR, iSwap, CY, SX, SXdg, DCX to the Clifford class Add the gates ECR, iSwap, CY, SX, SXdg, DCX to the Clifford class Feb 21, 2023
@ShellyGarion ShellyGarion added Changelog: Bugfix Include in the "Fixed" section of the changelog and removed Changelog: New Feature Include in the "Added" section of the changelog labels Feb 22, 2023
@ShellyGarion ShellyGarion modified the milestones: 0.24.0, 0.23.2 Feb 22, 2023
@ShellyGarion ShellyGarion added the stable backport potential The bug might be minimal and/or import enough to be port to stable label Feb 22, 2023
@mergify mergify bot merged commit 9128ebd into Qiskit:main Feb 22, 2023
mergify bot pushed a commit that referenced this pull request Feb 22, 2023
@ShellyGarion @mergify
Add the gates ECR, iSwap, CY, SX, SXdg, DCX to the Clifford class (#9623
39b2dcb 
)

* add SX and SXdg gates

* add CY, iSwap and ECR gates

* add new gates to the Clifford docs

* improve ECR

* add more tests for the new gates

* add ECR decomposition into Clifford gates to the equivalence library

* update ECR in equivalence library

* add DCX to clifford_circuits.py

* add test for dcx

* add release notes

* more efficient synthesis of an ECR gate

* change the release notes from features to bug fix

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 9128ebd)
@mergify mergify bot mentioned this pull request Feb 22, 2023
Merged
mergify bot added a commit that referenced this pull request Feb 22, 2023
@mergify @ShellyGarion
Add the gates ECR, iSwap, CY, SX, SXdg, DCX to the Clifford class (#9623
c1bcdc9 
) (#9640)

* add SX and SXdg gates

* add CY, iSwap and ECR gates

* add new gates to the Clifford docs

* improve ECR

* add more tests for the new gates

* add ECR decomposition into Clifford gates to the equivalence library

* update ECR in equivalence library

* add DCX to clifford_circuits.py

* add test for dcx

* add release notes

* more efficient synthesis of an ECR gate

* change the release notes from features to bug fix

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 9128ebd)

Co-authored-by: Shelly Garion <[email protected]>
Eric-Arellano pushed a commit to Eric-Arellano/qiskit-terra that referenced this pull request Feb 23, 2023
@ShellyGarion @mergify @Eric-Arellano
Add the gates ECR, iSwap, CY, SX, SXdg, DCX to the Clifford class (Qi…
53d2316 
…skit#9623)

* add SX and SXdg gates

* add CY, iSwap and ECR gates

* add new gates to the Clifford docs

* improve ECR

* add more tests for the new gates

* add ECR decomposition into Clifford gates to the equivalence library

* update ECR in equivalence library

* add DCX to clifford_circuits.py

* add test for dcx

* add release notes

* more efficient synthesis of an ECR gate

* change the release notes from features to bug fix

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@itoko itoko mentioned this pull request May 8, 2023
Closed
@ShellyGarion ShellyGarion mentioned this pull request Mar 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakelishman jakelishman jakelishman approved these changes

@ikkoham ikkoham Awaiting requested review from ikkoham

@itoko itoko Awaiting requested review from itoko

Assignees
No one assigned
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog mod: quantum info Related to the Quantum Info module (States & Operators) stable backport potential The bug might be minimal and/or import enough to be port to stable synthesis
Projects
None yet
Milestone
0.23.2
Development

Successfully merging this pull request may close these issues.

Add ECR/iSwap to list of gates handled by Clifford.from_circuit
5 participants
@ShellyGarion @qiskit-bot @coveralls @jakelishman @itoko