-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MinimumPoint transpiler pass #9612
Merged
Merged
Commits on Mar 29, 2023
-
Add MinimumPoint transpiler pass
This commit adds a new transpiler pass MinimumPoint which is used to find a local minimum point from the property set between executions of the pass. This is similar to the existing FixedPoint pass but will find the minimum fixed point over the past n exeuctions as opposed to finding a when two subsequent exectuions are at the same point. This is then used in optimization level 3 because the 2q unitary synthesis optimization that is part of the optimization loop can occasionally get stuck oscillating between multiple different equivalent decompositions which prevents the fixed point condition from ever being reached. By checking that we've reached the minimum over the last 5 executions we ensure we're reaching an exit condition in this situation. Fixes Qiskit#5832 Fixes Qiskit#9177 (the underlying cause of the optimization loop's inability to converge at optimization level 3 is not fixed here, there is still a root cause of instability in UnitarySynthesis this just changes the loop exit condition so we're never stuck in an infinte loop)
Configuration menu - View commit details
-
Copy full SHA for 9763e6f - Browse repository at this point
Copy the full SHA 9763e6fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e96ad7 - Browse repository at this point
Copy the full SHA 8e96ad7View commit details -
Rework logic to track state with a dataclass
This commit reworks the logic of the pass to track the state via a dataclass instead of using separate property set fields. This cleans up the code for dealing with checking the current state relative to earlier iterations by making the access just attributes instead of secret strings. At the same time the tests were updated to handle this new data structure comments were added to better explain the logic flow being tested.
Configuration menu - View commit details
-
Copy full SHA for e2c8cd0 - Browse repository at this point
Copy the full SHA e2c8cd0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3f74311 - Browse repository at this point
Copy the full SHA 3f74311View commit details
Commits on Mar 30, 2023
-
Apply suggestions from code review
Co-authored-by: Jake Lishman <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e603007 - Browse repository at this point
Copy the full SHA e603007View commit details -
Configuration menu - View commit details
-
Copy full SHA for a339bb1 - Browse repository at this point
Copy the full SHA a339bb1View commit details -
Configuration menu - View commit details
-
Copy full SHA for f889fbd - Browse repository at this point
Copy the full SHA f889fbdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0581884 - Browse repository at this point
Copy the full SHA 0581884View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.