Add commutator functions to quantum_info #9546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikkoham
added
Changelog: New Feature
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 4554653888
💛 - Coveralls |
mrossinek
reviewed
Feb 8, 2023
Cryoris
reviewed
Feb 8, 2023
Cryoris
reviewed
Feb 8, 2023
|
Thank you very much for great suggestions. I improved codes. |
Cryoris
reviewed
Feb 24, 2023
ikkoham
commented
Feb 27, 2023
Cryoris
reviewed
Mar 23, 2023
Cryoris
previously approved these changes
Mar 23, 2023
Cryoris
approved these changes
Mar 31, 2023
|
@Cryoris Thank you! |
giacomoRanieri
pushed a commit
to giacomoRanieri/qiskit-terra
that referenced
this pull request
Apr 16, 2023
* Add commutator functions to quantum_info * clear reference * add tests * improve docs and rename arg * improve type hint * Apply suggestions from code review Co-authored-by: Julien Gacon <[email protected]> * split files * fix test (rename args) * rename var * rename var * Update docstring * black --------- Co-authored-by: Julien Gacon <[email protected]>
king-p3nguin
pushed a commit
to king-p3nguin/qiskit-terra
that referenced
this pull request
May 22, 2023
* Add commutator functions to quantum_info * clear reference * add tests * improve docs and rename arg * improve type hint * Apply suggestions from code review Co-authored-by: Julien Gacon <[email protected]> * split files * fix test (rename args) * rename var * rename var * Update docstring * black --------- Co-authored-by: Julien Gacon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add commutator functions to quantum_info.
Note that unlike opflow, it does not perform
reduce(simplify) method. This is becauseLinearOpis not guaranteed to have a simplify method. Therefore, when calling it, users must explicitly simplify after the call if necessary.Details and comments