Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fake backend not to use deprecated arguments in NoiseModel construction #9542

Merged
merged 1 commit into from
Feb 7, 2023
Merged

Fix fake backend not to use deprecated arguments in NoiseModel construction #9542

merged 1 commit into from
Feb 7, 2023

Conversation

itoko
Copy link
Contributor

@itoko itoko commented Feb 7, 2023

Summary

Update fake backend not to use deprecated arguments, standard_gates and warnings, in the construction of a noise model for simulation.

@itoko itoko requested review from a team and jyu00 as code owners February 7, 2023 10:45
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@itoko itoko added stable backport potential The bug might be minimal and/or import enough to be port to stable Changelog: Bugfix Include in the "Fixed" section of the changelog labels Feb 7, 2023
@itoko itoko added this to the 0.23.2 milestone Feb 7, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4113053752

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 85.279%

Totals Coverage Status
Change from base Build 4107383485: 0.003%
Covered Lines: 67252
Relevant Lines: 78861

💛 - Coveralls

Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, seems straightforward enough. Do we need to backport this for 0.23.2? (Nevermind I see you tagged it as backport potential already)

@mergify mergify bot merged commit 1a98f7a into Qiskit:main Feb 7, 2023
mergify bot pushed a commit that referenced this pull request Feb 7, 2023
(cherry picked from commit 1a98f7a)
mergify bot added a commit that referenced this pull request Feb 7, 2023
(cherry picked from commit 1a98f7a)

Co-authored-by: Toshinari Itoko <[email protected]>
pranay1990 pushed a commit to pranay1990/qiskit-terra that referenced this pull request Feb 9, 2023
ElePT pushed a commit to ElePT/qiskit-ibm-provider that referenced this pull request Oct 4, 2023
ElePT pushed a commit to ElePT/qiskit-ibm-runtime that referenced this pull request Oct 10, 2023
ElePT pushed a commit to ElePT/qiskit that referenced this pull request Oct 12, 2023
ElePT pushed a commit to ElePT/qiskit-ibm-runtime that referenced this pull request Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants