Fix performance of ReverseEstimatorGradient for partial gradients
#9491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cryoris
added
stable backport potential
Cryoris
requested review from
a team,
manoelmarques,
woodsp-ibm and
ElePT
as code owners
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
ElePT
approved these changes
Jan 31, 2023
jakelishman
approved these changes
Jan 31, 2023
mergify bot
added a commit
that referenced
this pull request
Jan 31, 2023
…#9491) (#9492) * Use append over += * add reno (cherry picked from commit 729f7d1) Co-authored-by: Julien Gacon <[email protected]>
Pull Request Test Coverage Report for Build 4053970489
💛 - Coveralls |
ElePT
pushed a commit
to ElePT/qiskit
that referenced
this pull request
Jun 27, 2023
…Qiskit#9491) * Use append over += * add reno
ElePT
pushed a commit
to ElePT/qiskit-algorithms-test
that referenced
this pull request
Jul 17, 2023
…Qiskit/qiskit#9491) * Use append over += * add reno
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
ReverseEstimatorGradientdid a lot of unnecessary copies if the circuit contained many gates with respect to whose parameter we didn't derive. That meant that e.g. computing all derivatives of a 100-parameter circuit was faster than computing only a single derivative.Details and comments
The circuit splitting used
instead of just
subcircuit.append. The first seems to copy all circuit instructions, which gets very expensive if called many times.Here's a profiling for computing 7 of ~100 parameters in an
EfficientSU2circuit before the fix:and after