Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tweedledum to requirements-dev.txt #9477

Merged
merged 2 commits into from
Jan 27, 2023
Merged

Add tweedledum to requirements-dev.txt #9477

merged 2 commits into from
Jan 27, 2023

Commits on Jan 27, 2023

  1. Add tweedledum to requirements-dev.txt 

    This commit adds a tweedledum to the requirements-dev.txt list. Since
the release of qiskit-terra 0.23.0 the CI docs job has started to fail.
This is because tweedledum is a requirement for the classicalfunction
compiler docs. It turns out we were getting tweedledum installed in docs
build jobs via a weird path. The install order for docs build was
installing packages that require qiskit-terra before terra itself was
being installed. This would cause qiskit-terra from pypi from being
isntalled first, and old versions of terra required tweedledum which
would install it. Then we'd later upgrade terra to the current version
under test. To fix this in the short term this adds add tweedledum to
the requirements list so we unblock CI. One thing to note is that since
the primary reason we removed tweedledum from the requirements list
in Qiskit#8947 was because macOS users were not able to install it reliably
the new entry in the requirement-dev.txt list does not cause issues for
developers on macOS systems.

Longer term we should make two fixes, first we need to update the
classicalfunction compiler docs so they build without having tweedledum
installed. The second is we should update the CI job to avoid installing
terra from pypi before we build it from source. But, given that CI is
currently broken just adding it to the requirements-dev.txt list is the
fastest fix.
    @mtreinish
    mtreinish committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    9c64884 View commit details
    Browse the repository at this point in the history

  2. Exclude tweedledum on Python 3.11 too

    @mtreinish
    mtreinish committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    6c52ef1 View commit details
    Browse the repository at this point in the history