Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DagDepNode.condition (deprecated in #6110) #9406

Merged
merged 10 commits into from
Feb 6, 2023

Conversation

1ucian0
Copy link
Member

@1ucian0 1ucian0 commented Jan 20, 2023

In 0.18, DagDepNode.condition was deprecated.

@1ucian0 1ucian0 requested a review from a team as a code owner January 20, 2023 14:14
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@coveralls
Copy link

coveralls commented Jan 20, 2023

Pull Request Test Coverage Report for Build 4105029567

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.009%) to 85.282%

Totals Coverage Status
Change from base Build 4104989273: 0.009%
Covered Lines: 67245
Relevant Lines: 78850

💛 - Coveralls

qiskit/dagcircuit/dagdepnode.py Outdated Show resolved Hide resolved
releasenotes/notes/6110-709f6fa891bdb26b.yaml Outdated Show resolved Hide resolved
@1ucian0 1ucian0 added the Changelog: Removal Include in the Removed section of the changelog label Feb 4, 2023
@1ucian0 1ucian0 added this to the 0.24.0 milestone Feb 5, 2023
@kdk kdk changed the title DagDepNode.condition (deprecated in #6110) Remove DagDepNode.condition (deprecated in #6110) Feb 6, 2023
@kdk kdk added the automerge label Feb 6, 2023
@mergify mergify bot merged commit 377b46b into Qiskit:main Feb 6, 2023
@1ucian0 1ucian0 deleted the remove/DAGNode.condition/6110/1 branch February 7, 2023 19:53
pranay1990 pushed a commit to pranay1990/qiskit-terra that referenced this pull request Feb 9, 2023
* remove DAGNode.condition

* reno

* Update releasenotes/notes/6110-709f6fa891bdb26b.yaml

Co-authored-by: Jake Lishman <[email protected]>

* extend release notes

* Update qiskit/dagcircuit/dagdepnode.py

Co-authored-by: Jake Lishman <[email protected]>

---------

Co-authored-by: Jake Lishman <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Removal Include in the Removed section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants