-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FakePrague Egret R1 to fake backends #9369
Conversation
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, before I approve though can you add FakePrague
to the list of backends in FakeProviderForBackendV2
in qiskit/providers/fake_provider/fake_provider.py
. That will use it in the test suite to validate everything works with it. Also we've been adding the fake backends off of qiskit/provider/fake_provider/__init__.py
and including them in the autosummary for the docs.
Co-authored-by: Matthew Treinish <[email protected]>
Ok, hopefully that addresses those issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the quick updates.
@Mergifyio requeue |
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically |
* Add FakePrague device * Add release note * Update releasenotes/notes/add_fake_prague-79f82b83c2e2329c.yaml Co-authored-by: Matthew Treinish <[email protected]> * Add suggestions Co-authored-by: Matthew Treinish <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* Add FakePrague device * Add release note * Update releasenotes/notes/add_fake_prague-79f82b83c2e2329c.yaml Co-authored-by: Matthew Treinish <[email protected]> * Add suggestions Co-authored-by: Matthew Treinish <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* Add FakePrague device * Add release note * Update releasenotes/notes/add_fake_prague-79f82b83c2e2329c.yaml Co-authored-by: Matthew Treinish <[email protected]> * Add suggestions Co-authored-by: Matthew Treinish <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* Add FakePrague device * Add release note * Update releasenotes/notes/add_fake_prague-79f82b83c2e2329c.yaml Co-authored-by: Matthew Treinish <[email protected]> * Add suggestions Co-authored-by: Matthew Treinish <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Summary
Adds the Prague device to the fake backends
Details and comments
Pulse defaults is not included as there is an error importing them. However, this adds a new system with
cz
entangling gates, and thus is a nice addition to the fake backends.