Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PauliOp matmul with iI & add PauliOp test #9321

Merged
merged 8 commits into from
Jan 17, 2023

Conversation

king-p3nguin
Copy link
Contributor

@king-p3nguin king-p3nguin commented Dec 24, 2022

@qiskit-bot qiskit-bot added the Community PR PRs from contributors that are not 'members' of the Qiskit repo label Dec 24, 2022
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

@woodsp-ibm woodsp-ibm added the mod: opflow Related to the Opflow module label Dec 25, 2022
@coveralls
Copy link

coveralls commented Dec 27, 2022

Pull Request Test Coverage Report for Build 3940522074

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 84.833%

Totals Coverage Status
Change from base Build 3940320475: 0.002%
Covered Lines: 65658
Relevant Lines: 77397

💛 - Coveralls

@ikkoham ikkoham added this to the 0.23.0 milestone Jan 10, 2023
Copy link
Contributor

@ikkoham ikkoham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. Thanks. The change looks good to me.

Could you move the test to the following file instead of creating new one?
https://github.com/Qiskit/qiskit-terra/blob/main/test/python/opflow/test_op_construction.py

@ikkoham ikkoham self-assigned this Jan 10, 2023
@king-p3nguin
Copy link
Contributor Author

Thank you for reviewing! I transferred the tests.

@ikkoham ikkoham added the Changelog: Bugfix Include in the "Fixed" section of the changelog label Jan 17, 2023
Copy link
Contributor

@ikkoham ikkoham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for achieving my comment! LGTM!

@mergify mergify bot merged commit e9426c2 into Qiskit:main Jan 17, 2023
@king-p3nguin king-p3nguin deleted the pr-fix-PauliOp-matmul branch January 17, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog Community PR PRs from contributors that are not 'members' of the Qiskit repo mod: opflow Related to the Opflow module
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

PauliOp matmul gives incorrect result with iI
5 participants