-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix PauliOp matmul with iI & add PauliOp test #9321
Conversation
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 3940522074
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch. Thanks. The change looks good to me.
Could you move the test to the following file instead of creating new one?
https://github.com/Qiskit/qiskit-terra/blob/main/test/python/opflow/test_op_construction.py
Thank you for reviewing! I transferred the tests. |
e2b802d
to
9c11b58
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for achieving my comment! LGTM!
Summary
Details and comments
https://github.com/Qiskit/qiskit-terra/blob/4b860332a69ebfa8a4b52e0ab5dd6c753db5c39e/qiskit/opflow/primitive_ops/pauli_op.py#L157-L159