Adding global_phase gate in qiskit-terra #9251

sumit-kale · 2022-12-06T15:05:55Z

Summary

Added global phase gate (global_phase) which can be applied to a:class:~qiskit.circuit.QuantumCircuit
This PR fixes Global phase gate #8236 issue.

Details and comments

Added relevant test functions in test_extensions_standard.py
Release notes have been added
Passes lint checks locally

…anch1

…into branch1

…anch1

…into branch1

sumit-kale · 2023-04-11T17:44:15Z

It looks like Jake's fix #9899 resolves the issue. It would be good to add a test case for that.

I have added the test case for that! Thanks for the suggestion.

jakelishman

It looks like you've had some problems with merge conflicts in the places I've highlighted here - are you able to fix them yourself, or do you need a hand?

qiskit/circuit/library/standard_gates/__init__.py

jakelishman · 2023-04-13T17:27:29Z

qiskit/circuit/library/standard_gates/__init__.py

+<<<<<<< HEAD
+=======
 Standard gates
+>>>>>>> 5672c70649b4f83a6c7146c68a6a543d4a3908fd
+=======
+>>>>>>> 57939ba279d95b5e3f56a08e186f5e1459c3c44f


jakelishman

Thank you for looking at this. I've just got a couple of book-keeping comments, nothing meaningful about your new gate itself. If you're able to get these changes fixed in the next week, we'll release this as part of Qiskit Terra 0.24 soon!

If you need a hand / don't have time, don't worry - just let me know and I'll fix up the last few things myself and merge it.

qiskit/circuit/library/standard_gates/__init__.py

qiskit/circuit/library/standard_gates/global_phase.py

test/python/circuit/test_extensions_standard.py

jakelishman · 2023-04-13T17:42:51Z

I've also made #9962 to track the issue of the visualisation that we discussed above. That doesn't need solving for this PR, it's just so we don't forget (as easily).

jakelishman

Thanks for all the work on this! I've fixed up the merge conflict that had just arisen, and I'll tag this for merge now. There's nothing more you need to do - the PR will update itself and merge when it reaches the head of the queue.

coveralls · 2023-04-17T12:31:12Z

Pull Request Test Coverage Report for Build 4721851712

22 of 22 (100.0%) changed or added relevant lines in 3 files are covered.
179 unchanged lines in 11 files lost coverage.
Overall coverage increased (+0.05%) to 85.83%

Files with Coverage Reduction	New Missed Lines	%
crates/qasm2/src/expr.rs	1	93.76%
qiskit/assembler/run_config.py	1	94.74%
qiskit/circuit/tools/pi_check.py	1	91.23%
qiskit/pulse/library/waveform.py	3	91.67%
crates/accelerate/src/sabre_swap/layer.rs	4	97.32%
crates/qasm2/src/lex.rs	4	90.89%
qiskit/compiler/assembler.py	6	96.13%
qiskit/execute_function.py	6	87.5%
qiskit/qobj/qasm_qobj.py	35	83.27%
qiskit/qobj/pulse_qobj.py	41	78.47%

Totals
Change from base Build 4720871645:	0.05%
Covered Lines:	70549
Relevant Lines:	82196

💛 - Coveralls

kevinsung · 2023-04-17T13:08:52Z

What is the expected behavior if this gate is controlled? Does it remain a global phase or does it become a conditional global phase/relative phase?

It should be the latter. For example, if the control is a single qubit, then the result is a PhaseGate.

Please add a test that controlling a GlobalPhaseGate behaves correctly, as described in this comment.

jakelishman · 2023-04-17T13:38:34Z

I would say that we don't 100% need to ensure that .control produces an exact class as its output (that's an implementation detail), just that the matrix output of the output comes out mathematically correct. I've added some tests of that in 64ea9e6.

kevinsung

Great, thanks!

@DaTa

* created gphase.py file * completed glbalphase file & test_gate_defin * adding GphaseGate in @DaTa in test_gate_defn * added reno add-global-phase * added inv and matrix test in test_exten * test_gphase_inv * tox lint edit * renamed GLobalPhaseGate to Global_Phase_Gate * Changed the name to more competable GlobalPhaseGate class * # pylint: disable=E1101 * # pylint: disable=no-member * # pylint: error fixed * including phase in super * changed float to ParameterExp * modified test_globalphaseGate * phase to params[0] * renamed global_phase.py to gphase * test gphase new in extentions_std * debug 1 * debug 2 * debug 3 instructions set * debug 4 * debug 5 * debug 6 * debug 6 instructions set * debug 7 * debug 7 * added gphase in quantumcircuit.py * added method gphase in quantumcircuit.py * test_gphase_inv * gphase debug1 * gphase debug2 * gphase debug3 * inverse mtd in gphase.py * added _array in gphase.py * gphase.py array debug1 * test_matrix gphase complex dtype * test_matrix in @DDT * test_gphase_matrix * changed gphase to global_phase * removed extra comma l871 * typo in reno fixed * modified reno * Delete .vs directory Deleted .vs directory * Added test to check compatibility of gate with qc.attri * debugged pylint error1 * debugged pylint error2 * debugged pylint error2a * debugged -epy error debug1 * debugged -epy error debug 1 * debugged -epy error debug 2 * restored test_gate_definations * Revert "restored test_gate_definations" This reverts commit 642877b. * reverted mistakely edited the file on Github * Delete .vs directory Deleted .vs directory * restored test_gate_definations * Revert "restored test_gate_definations" This reverts commit 642877b. * reverted mistakely edited the file on Github * retrived test_gate_definitions * PR modifications new * commit feb 13 * range in append * [] in append * [0] in append * [0]->[] * [0] * [] * Operator(qc) * fixed test_ex_std * resolved changes suggested by Cryolis * Update global_phase.py Typo in year * Added transpiler consistancy test * restored the docstring * prevented cyclic imports and other changes * Fix spacing in docs * Fix lint * Add test of controlling global phase --------- Co-authored-by: Jake Lishman <[email protected]>

sumit-kale and others added 30 commits October 10, 2022 22:53

created gphase.py file

aa8f608

Merge branch 'Qiskit:main' into branch1

89157f8

Merge branch 'main' of https://github.com/Qiskit/qiskit-terra into br…

e2c97a7

…anch1

completed glbalphase file & test_gate_defin

14f5599

adding GphaseGate in @DaTa in test_gate_defn

edcf7ba

Merge branch 'main' of https://github.com/Qiskit/qiskit-terra into br…

87a2ade

…anch1

Merge branch 'branch1' of https://github.com/sumit-kale/qiskit-terra …

1aac540

…into branch1

Merge branch 'main' of https://github.com/Qiskit/qiskit-terra into br…

6a3e453

…anch1

added reno add-global-phase

8051f10

Merge branch 'main' of https://github.com/Qiskit/qiskit-terra into br…

9be8cda

…anch1

added inv and matrix test in test_exten

d06e4f4

test_gphase_inv

b5320ef

tox lint edit

55e874b

renamed GLobalPhaseGate to Global_Phase_Gate

c7b3390

Changed the name to more competable GlobalPhaseGate class

9f2ba8a

# pylint: disable=E1101

9c9d77f

# pylint: disable=no-member

64f5d7f

# pylint: error fixed

22573b2

including phase in super

c3d484e

Merge branch 'Qiskit:main' into branch1

be943b0

Merge branch 'branch1' of https://github.com/sumit-kale/qiskit-terra …

86267bc

…into branch1

changed float to ParameterExp

025912e

modified test_globalphaseGate

618816c

phase to params[0]

32a4401

renamed global_phase.py to gphase

371fbc3

test gphase new in extentions_std

615c9fc

debug 1

c910dcd

debug 2

0661cd5

debug 3 instructions set

b071cd6

debug 4

6461819

sumit-kale added 2 commits April 10, 2023 12:57

resolved merge conflicts

098d85b

Added transpiler consistancy test

a1bac05

jakelishman reviewed Apr 13, 2023

View reviewed changes

jakelishman mentioned this pull request Apr 13, 2023

Support zero-operand instructions in circuit drawers #9962

Open

sumit-kale and others added 4 commits April 16, 2023 14:11

restored the docstring

eedbf55

prevented cyclic imports and other changes

546872e

Fix spacing in docs

394e4f4

Merge remote-tracking branch 'ibm/main' into global_phase

7dc02bb

jakelishman previously approved these changes Apr 17, 2023

View reviewed changes

jakelishman enabled auto-merge April 17, 2023 12:05

Fix lint

eb2b7bc

jakelishman dismissed their stale review via eb2b7bc April 17, 2023 12:42

jakelishman previously approved these changes Apr 17, 2023

View reviewed changes

Add test of controlling global phase

64ea9e6

jakelishman dismissed their stale review via 64ea9e6 April 17, 2023 13:37

jakelishman disabled auto-merge April 17, 2023 13:37

kevinsung approved these changes Apr 17, 2023

View reviewed changes

jakelishman approved these changes Apr 17, 2023

View reviewed changes

jakelishman enabled auto-merge April 17, 2023 13:59

jakelishman added this pull request to the merge queue Apr 17, 2023

Merged via the queue into Qiskit:main with commit da92478 Apr 17, 2023

jakelishman added the Changelog: New Feature Include in the "Added" section of the changelog label Apr 17, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding global_phase gate in qiskit-terra #9251

Adding global_phase gate in qiskit-terra #9251

sumit-kale commented Dec 6, 2022

sumit-kale commented Apr 11, 2023

jakelishman left a comment

jakelishman Apr 13, 2023

sumit-kale Apr 16, 2023

jakelishman left a comment

jakelishman commented Apr 13, 2023

jakelishman left a comment

coveralls commented Apr 17, 2023 •

edited

Loading

kevinsung commented Apr 17, 2023

jakelishman commented Apr 17, 2023

kevinsung left a comment

Adding global_phase gate in qiskit-terra #9251

Adding global_phase gate in qiskit-terra #9251

Conversation

sumit-kale commented Dec 6, 2022

Summary

Details and comments

sumit-kale commented Apr 11, 2023

jakelishman left a comment

Choose a reason for hiding this comment

jakelishman Apr 13, 2023

Choose a reason for hiding this comment

sumit-kale Apr 16, 2023

Choose a reason for hiding this comment

jakelishman left a comment

Choose a reason for hiding this comment

jakelishman commented Apr 13, 2023

jakelishman left a comment

Choose a reason for hiding this comment

coveralls commented Apr 17, 2023 • edited Loading

Pull Request Test Coverage Report for Build 4721851712

💛 - Coveralls

kevinsung commented Apr 17, 2023

jakelishman commented Apr 17, 2023

kevinsung left a comment

Choose a reason for hiding this comment

coveralls commented Apr 17, 2023 •

edited

Loading