Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated functions from ParameterView #9184

Merged
merged 4 commits into from
Nov 24, 2022

Conversation

jakelishman
Copy link
Member

Summary

These were deprecated since Terra 0.17, when the type of the return changed.

Details and comments

These were deprecated since Terra 0.17, when the type of the return
changed.
@jakelishman jakelishman added the Changelog: Removal Include in the Removed section of the changelog label Nov 22, 2022
@jakelishman jakelishman requested a review from a team as a code owner November 22, 2022 19:34
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@coveralls
Copy link

coveralls commented Nov 22, 2022

Pull Request Test Coverage Report for Build 3542596746

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.06%) to 84.554%

Files with Coverage Reduction New Missed Lines %
src/sabre_swap/layer.rs 3 98.43%
Totals Coverage Status
Change from base Build 3541974265: 0.06%
Covered Lines: 62838
Relevant Lines: 74317

💛 - Coveralls

Copy link
Contributor

@Cryoris Cryoris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@mergify mergify bot merged commit c063c91 into Qiskit:main Nov 24, 2022
Cryoris pushed a commit to Cryoris/qiskit-terra that referenced this pull request Jan 12, 2023
* Remove deprecated functions from `ParameterView`

These were deprecated since Terra 0.17, when the type of the return
changed.

* Restore non-deprecated function

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@jakelishman jakelishman deleted the remove-deprecated-parameterview branch January 16, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Removal Include in the Removed section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants