Fix C3SXGate roundtrip in OpenQASM 2 #9183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qiskit and its version of `qelib1.inc` give `C3SXGate` different names: `c3sx` and `c3sqrtx` respectively. At this point, changing either of these two names is likely to cause user pain, and it should not be difficult for the OpenQASM 2 exporter to simply know about this remapping, like it knows about other standard gate mappings. In practice, the structure of the exporter makes this rather difficult, but we need not expose that complexity to users.
jakelishman
added
Changelog: Bugfix
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this: |
3 tasks
Pull Request Test Coverage Report for Build 4118341310
💛 - Coveralls |
1ucian0
approved these changes
Feb 7, 2023
pranay1990
pushed a commit
to pranay1990/qiskit-terra
that referenced
this pull request
Feb 9, 2023
* Fix C3SXGate roundtrip in OpenQASM 2 Qiskit and its version of `qelib1.inc` give `C3SXGate` different names: `c3sx` and `c3sqrtx` respectively. At this point, changing either of these two names is likely to cause user pain, and it should not be difficult for the OpenQASM 2 exporter to simply know about this remapping, like it knows about other standard gate mappings. In practice, the structure of the exporter makes this rather difficult, but we need not expose that complexity to users. * Correct namespace lookup * Break import cycle --------- Co-authored-by: Luciano Bello <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Qiskit and its version of
qelib1.incgiveC3SXGatedifferent names:c3sxandc3sqrtxrespectively. At this point, changing either of these two names is likely to cause user pain, and it should not be difficult for the OpenQASM 2 exporter to simply know about this remapping, like it knows about other standard gate mappings. In practice, the structure of the exporter makes this rather difficult, but we need not expose that complexity to users.Details and comments
Fix #7148.
Close #7241 (obsolete).
This PR is a more conservative version of #7148 that does not break backwards compatibility, and does not require changes to either Terra's version of
qelib1.incor the name ofC3SXGate, both of which may cause user headaches.It should have been easier to do this output mapping (the general exporter should know how classes / names need to be mapped to OQ2 equivalents), but as it stands, it needs to be hacked in a little bit. This way is cleaner for the user experience, though.