Reinstate pulse.Instruction.draw
#9144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was erroneously broken by Qiskitgh-8306 and not detected by lint because of the existence of `qiskit.visualization.__getattr__`. This reinstates the functionality using the deprecated old instruction drawers.
jakelishman
added
stable backport potential
jakelishman
requested review from
a team,
eggerdj and
wshanks
as code owners
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 3482318380
💛 - Coveralls |
mtreinish
approved these changes
Nov 16, 2022
mergify bot
pushed a commit
that referenced
this pull request
Nov 16, 2022
This was erroneously broken by gh-8306 and not detected by lint because of the existence of `qiskit.visualization.__getattr__`. This reinstates the functionality using the deprecated old instruction drawers. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit da1a7e3)
mergify bot
added a commit
that referenced
this pull request
Nov 16, 2022
This was erroneously broken by gh-8306 and not detected by lint because of the existence of `qiskit.visualization.__getattr__`. This reinstates the functionality using the deprecated old instruction drawers. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit da1a7e3) Co-authored-by: Jake Lishman <[email protected]>
Cryoris
pushed a commit
to Cryoris/qiskit-terra
that referenced
this pull request
Jan 12, 2023
This was erroneously broken by Qiskitgh-8306 and not detected by lint because of the existence of `qiskit.visualization.__getattr__`. This reinstates the functionality using the deprecated old instruction drawers. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This was erroneously broken by gh-8306 and not detected by lint because of the existence of
qiskit.visualization.__getattr__. This reinstates the functionality using the deprecated old instruction drawers.Details and comments
I'm using the deprecated functionality, achieved by inlining what the old
pulse_drawer(v1) code did for this path, because the paths in use haven't been triggering their deprecation warnings properly due tostacklevelissues, so are not eligible for immediate removal. This PR is stable for backport (fixes a bug in the deprecation period), and I'll follow it with a PR for 0.23 that applies the deprecations to the v1 pulse drawer (and this method) correctly.