-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stabilising test_squ #9083
Stabilising test_squ #9083
Conversation
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 3404493696
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That comma is actually fine, and (at least in the UK, I believe) it's more common to introduce non-defining clauses (using "which" rather than "that") with a comma. It doesn't matter, though.
* stabilized squ tests * seeding rng Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit b224a2e)
* stabilized squ tests * seeding rng Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit b224a2e) Co-authored-by: Luciano Bello <[email protected]>
* stabilized squ tests * seeding rng Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Coveralls had been complaining about
/qiskit/extensions/quantum_initializer/squ.py
unstable coverage. For example:There was a missing seeding in a test. I also moved it to ddt.