Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated networkx dag converter functions #9035

Merged
merged 8 commits into from
Nov 3, 2022

Conversation

mtreinish
Copy link
Member

Summary

This commit removes the deprecated DAGCircuit and DAGDependency networkx converter functions. These functions were deprecated in #7927 as part of the 0.21.0 release. Since the minimum deprecation window has elapsed we can now remove these functions and the last usage of optional networkx usage in qiskit terra.

Details and comments

This commit removes the deprecated DAGCircuit and DAGDependency
networkx converter functions. These functions were deprecated
in Qiskit#7927 as part of the 0.21.0 release. Since the minimum
deprecation window has elapsed we can now remove these functions and
the last usage of optional networkx usage in qiskit terra.
@mtreinish mtreinish added the Changelog: Removal Include in the Removed section of the changelog label Oct 29, 2022
@mtreinish mtreinish added this to the 0.23.0 milestone Oct 29, 2022
@mtreinish mtreinish requested a review from a team as a code owner October 29, 2022 12:00
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@coveralls
Copy link

coveralls commented Oct 29, 2022

Pull Request Test Coverage Report for Build 3385156307

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 84.525%

Totals Coverage Status
Change from base Build 3385148146: 0.06%
Covered Lines: 62340
Relevant Lines: 73753

💛 - Coveralls

jakelishman
jakelishman previously approved these changes Nov 1, 2022
jakelishman
jakelishman previously approved these changes Nov 2, 2022
@mtreinish
Copy link
Member Author

Sigh, the tutorials job fails because it was relying on the requirements-dev.txt entry to install networkx. I'll add networkx to the tutorials requirements list https://github.com/Qiskit/qiskit-terra/blob/main/.azure/tutorials-linux.yml#L27 in the meantime.

@mtreinish mtreinish force-pushed the remove-networkx-optional-usage branch from 5f283a9 to 92e50e8 Compare November 3, 2022 11:10
@mergify mergify bot merged commit 08969a6 into Qiskit:main Nov 3, 2022
jakelishman added a commit to jakelishman/qiskit-terra that referenced this pull request Nov 18, 2022
Since Qiskitgh-9035 this documentation has been out-of-date.  This updates it
to give the correct information.
mergify bot added a commit that referenced this pull request Nov 18, 2022
Since gh-9035 this documentation has been out-of-date.  This updates it
to give the correct information.

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Cryoris pushed a commit to Cryoris/qiskit-terra that referenced this pull request Jan 12, 2023
Since Qiskitgh-9035 this documentation has been out-of-date.  This updates it
to give the correct information.

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Removal Include in the Removed section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants