-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix transpile() with a Target containing an ideal Measure #8995
Merged
mergify
merged 2 commits into
Qiskit:main
from
mtreinish:fix-props-conversion-no-measure-props
Oct 28, 2022
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 10 additions & 0 deletions
10
releasenotes/notes/fix-transpile-ideal-measurement-c37e04533e196ded.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
--- | ||
fixes: | ||
- | | ||
Fixed an issue with :func:`~.transpile` when targeting a :class:`~.Target` | ||
(either directly via the ``target`` argument or via a | ||
:class:`~.BackendV2` instance from the ``backend`` argument) that | ||
contained an ideal :class:`~.Measure` instruction (one that does not have | ||
any properties defined). Previously this would raise an exception | ||
trying to parse the target. | ||
Fixed `#8969 <https://github.com/Qiskit/qiskit-terra/issues/8969>`__ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may be a too small nitpick in the original code, but these lines suggest we cannot mix ideal Measures and real Measures (if do that, real Measures will be silently converted to ideal Measures here, right?). Warning here (or allowing the mixture) might be nice. That said, I don't think of any practical use case of such a mixture, so I'm fine with keeping the code as is until we encounter any concrete issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good point, I do think it's unlikely in practice for there to be mixed ideal and real measurements but we should try to support that especially since it's possible combination and allowed in the target. The only reason we have to special case measurement here is because it's special in
BackendProperties
.