-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate Python 3.7 support #8942
Conversation
This commit deprecates Python 3.7 support. During the deprecation window we will continue to fully support Python 3.7 and test it in CI, but it will emit a warning that we will be removing support for 3.7 in the future to inform users to upgrade to Python 3.8 or newer. The removal will occur during the qiskit-terra 0.25.0 release as it is the first release scheduled to occur after the upstream Python EoL date in June 2023. [1] [1] https://devguide.python.org/versions/
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 3348648978
💛 - Coveralls |
I wouldn't be opposed to us considering doing the removal in Terra 0.24, if that's consistent with our policies (I can't remember), on the basis that Terra 0.24 will still be live while Python 3.7 goes EOL - if we wait til the version after, we officially have to support Python 3.7 after it's done. I'm also keen to drop Python 3.7 asap really, because the number of work-arounds we have in Terra for pre-Python-3.8 is already big, and it's only going to get bigger over the next 9 months til 0.25. |
Well, it'd violate the deprecation policy if we removed it during 0.24.0 because there isn't an intermediate release between the initial deprecation and the release removal. But we'll be able to remove it from |
Yeah, violating the policy is no good. I wish I'd remembered about it before we did 0.22, because I would have wanted to discuss it then. For maintenance: it's maintenance of the stable branch I'm concerned about - if something breaks in backport/user testing, we may well still need to be putting out more workarounds for an EOL Python into our latest of the software right up til the 0.25 release. But given that we missed the window to discuss it before 0.22, it's a fairly moot point now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm very much looking forwards to seeing the back of Python 3.7 (although that does feel a bit strange for me to say, since it was the version I used for most of my PhD!). I think it's good to get this merged in sooner rather than later, so people who care about avoiding the deprecation warnings (and test against main
Terra) have longer to react.
Summary
This commit deprecates Python 3.7 support. During the deprecation window we will continue to fully support Python 3.7 and test it in CI, but it will emit a warning that we will be removing support for 3.7 in the future to inform users to upgrade to Python 3.8 or newer. The removal will occur during the qiskit-terra 0.25.0 release as it is the first release scheduled to occur after the upstream Python EoL date in June 2023. [1]
Details and comments
[1] https://devguide.python.org/versions/