Fix LaTeX drawer on split-filesystem systems #8629
Conversation
Corrects issue Qiskit#8542
jmcelroy01
requested review from
a team,
nonhermitian and
nkanazawa1989
as code owners
qiskit-bot
added
the
Community PR
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
|
I'm unsure how to update a docstring (no. 2 in the pull request checklist). |
There was a problem hiding this comment.
The CI is just failing because of the code-style issue. If you move the import to the top block (between import os and import subprocess) it should be happy again.
It would be good to add a release note to document the bug fix as well, but that will generally involve you setting up a proper development environment for Terra (see our contributing guide), but if you've not got time, let me know and I can take care of it for you.
| @@ -488,7 +488,8 @@ def _latex_circuit_drawer( | |||
| image = utils._trim(image) | |||
| if filename: | |||
| if filename.endswith(".pdf"): | |||
| os.rename(base + ".pdf", filename) | |||
| import shutil | |||
There was a problem hiding this comment.
The import can go to the top of the file with the rest (I was just trying simplify the description of the change when I was asking you to try it out, sorry).
There was a problem hiding this comment.
Whoops, good point. I moved it.
jakelishman
changed the title
jakelishman
added
the
Changelog: Bugfix
|
Oh, I missed your comment before - don't worry about the docstring or adding additional tests for this change. There's no documentation change necessary at all, and there's not really a sensible way we can test the LaTeX compilation on a split filesystem in CI anyway. |
Yeah, please. I did the commits on Github directly. Will look into doing this for next time 😄 |
jakelishman
added
stable backport potential
Pull Request Test Coverage Report for Build 2949826278
💛 - Coveralls |
* Update circuit_visualization.py Corrects issue #8542 * Update circuit_visualization.py * Add release note Co-authored-by: Jake Lishman <[email protected]> (cherry picked from commit d163e89)
* Update circuit_visualization.py Corrects issue #8542 * Update circuit_visualization.py * Add release note Co-authored-by: Jake Lishman <[email protected]> (cherry picked from commit d163e89) Co-authored-by: Joseph McElroy <[email protected]>
Summary
Corrects issue #8542