Gradients with the primitives #8528

a-matsuo · 2022-08-12T06:55:33Z

Co-authored-by: Ikko Hamamura [email protected]
Co-authored-by: Takashi Imamichi [email protected]

Summary

This PR adds Finite Difference/Parameter Shift/Linear Comb. of Unitaries gradients with the primitives.
close #8496

Details and comments

There are 3 types of gradient methods for a sampler and estimator

Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]>

qiskit-bot · 2022-08-12T06:55:35Z

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

@Qiskit/terra-core
@manoelmarques
@woodsp-ibm

coveralls · 2022-08-12T08:50:27Z

Pull Request Test Coverage Report for Build 2992392546

656 of 679 (96.61%) changed or added relevant lines in 14 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 84.361%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
qiskit/algorithms/gradients/base_sampler_gradient.py	34	36	94.44%
qiskit/algorithms/gradients/finite_diff_estimator_gradient.py	39	41	95.12%
qiskit/algorithms/gradients/finite_diff_sampler_gradient.py	42	44	95.45%
qiskit/algorithms/gradients/lin_comb_estimator_gradient.py	60	62	96.77%
qiskit/algorithms/gradients/lin_comb_sampler_gradient.py	58	60	96.67%
qiskit/algorithms/gradients/param_shift_estimator_gradient.py	44	46	95.65%
qiskit/algorithms/gradients/param_shift_sampler_gradient.py	45	47	95.74%
qiskit/algorithms/gradients/spsa_estimator_gradient.py	44	46	95.65%
qiskit/algorithms/gradients/spsa_sampler_gradient.py	49	51	96.08%
qiskit/algorithms/gradients/utils.py	166	168	98.81%

Totals
Change from base Build 2990361532:	0.1%
Covered Lines:	57844
Relevant Lines:	68567

💛 - Coveralls

Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]>

…ra into gradients-primitives

qiskit/algorithms/gradients/finite_diff_estimator_gradient.py

Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]>

ikkoham

Thank you @a-matsuo. This is great work.
I left some high level (overall) comments. (I haven't checked the details of the implementation yet.)

qiskit/algorithms/gradients/base_estimator_gradient.py

qiskit/algorithms/gradients/estimator_gradient_result.py

qiskit/algorithms/gradients/__init__.py

qiskit/algorithms/gradients/sampler_gradient_result.py

ElePT

I have taken a look to compare with the Fidelity implementation and also left a few comments :)

qiskit/algorithms/gradients/base_estimator_gradient.py

qiskit/algorithms/gradients/finite_diff_estimator_gradient.py

qiskit/algorithms/gradients/base_sampler_gradient.py

qiskit/algorithms/gradients/base_estimator_gradient.py

Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]>

Cryoris

Here's some first comments, overall the setup looks good to me! I have some questions about caching below though 🙂

qiskit/algorithms/gradients/base_estimator_gradient.py

qiskit/algorithms/gradients/finite_diff_estimator_gradient.py

Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]>

add gradient test

qiskit/algorithms/gradients/lin_comb_estimator_gradient.py

Co-authored-by: Julien Gacon <[email protected]>

qiskit/algorithms/gradients/spsa_estimator_gradient.py

qiskit/algorithms/gradients/spsa_sampler_gradient.py

test/python/algorithms/test_estimator_gradient.py

Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]>

…ra into gradients-primitives

Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]>

qiskit/algorithms/gradients/finite_diff_estimator_gradient.py

qiskit/algorithms/gradients/spsa_sampler_gradient.py

releasenotes/notes/gradients-primitives-561cf9cf75a7ccb8.yaml

qiskit/algorithms/gradients/base_estimator_gradient.py

Cryoris

LGTM, thanks a lot for integrating all comments and the patience! 🙂

* added the gradients with the primitives Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]> * add run_options and supported gate Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]> * added unittests Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]> * lint Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]> * fix based on the comments Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]> * fix Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]> * add spsa gradient Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]> * simplify + async Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]> * added gradient variance Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]> * lint Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]> * added the run_options field Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]> * fix lint Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]> * fix based on comments Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]> * wip fix2 Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]> * fix Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]> * lint Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]> * fix epsilon and doc * lint Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]> * fix * Update qiskit/algorithms/gradients/base_sampler_gradient.py Co-authored-by: Takashi Imamichi <[email protected]> * Update qiskit/algorithms/gradients/base_sampler_gradient.py Co-authored-by: Takashi Imamichi <[email protected]> * Update qiskit/algorithms/gradients/base_estimator_gradient.py Co-authored-by: Takashi Imamichi <[email protected]> * Update qiskit/algorithms/gradients/base_sampler_gradient.py Co-authored-by: Takashi Imamichi <[email protected]> * Update qiskit/algorithms/gradients/base_estimator_gradient.py Co-authored-by: Takashi Imamichi <[email protected]> * Update qiskit/algorithms/gradients/base_estimator_gradient.py Co-authored-by: Takashi Imamichi <[email protected]> * change epsilon error Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]> * Update qiskit/algorithms/gradients/estimator_gradient_result.py Co-authored-by: Takashi Imamichi <[email protected]> * Update qiskit/algorithms/gradients/sampler_gradient_result.py Co-authored-by: Takashi Imamichi <[email protected]> * add gradient test * added batch size in spsa gradients Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]> * fix Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]> * lint * Update qiskit/algorithms/gradients/lin_comb_estimator_gradient.py Co-authored-by: Julien Gacon <[email protected]> * add operator tests Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]> * consistent name * rewrite spsa Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]> * use algorithm job Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]> Co-authored-by: Julien Gacon <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]>

commit a3076a50524a72f1bc91cb633ec5c67a765ef937 Merge: 06dfe40 b7e6329 Author: Erick Winston <[email protected]> Date: Wed Oct 5 09:02:28 2022 -0400 Merge branch 'main' into controlflow/stochastic_swap commit 06dfe40 Author: ewinston <[email protected]> Date: Tue Oct 4 23:34:42 2022 -0400 Update qiskit/transpiler/passes/routing/stochastic_swap.py Co-authored-by: Jake Lishman <[email protected]> commit 1487b80 Author: Erick Winston <[email protected]> Date: Tue Oct 4 23:33:34 2022 -0400 simplify function and naming of control flow layer transpilation function commit 5477c50 Author: Erick Winston <[email protected]> Date: Tue Oct 4 21:44:18 2022 -0400 replace "maxind" with "deepest_index" commit 02e704f Author: Erick Winston <[email protected]> Date: Tue Oct 4 21:40:06 2022 -0400 simplify determining idle qubits commit 753a637 Author: Erick Winston <[email protected]> Date: Tue Oct 4 20:39:11 2022 -0400 fix layer bug this fixes a bug where gates were dropped if they shared a layer with a control flow op. commit 4dd68a9 Author: Erick Winston <[email protected]> Date: Tue Oct 4 11:48:01 2022 -0400 remove _idle_wires function commit d74b6ee Author: Erick Winston <[email protected]> Date: Tue Oct 4 11:40:22 2022 -0400 remove utils function for getting qubit order commit 56029b1 Merge: 9d16884 53e215c Author: Erick Winston <[email protected]> Date: Tue Oct 4 09:30:58 2022 -0400 Merge branch 'main' into controlflow/stochastic_swap commit 9d16884 Author: Erick Winston <[email protected]> Date: Tue Oct 4 03:00:22 2022 -0400 make sure stochastic swap child instances get new seeds commit dc5b23c Author: Erick Winston <[email protected]> Date: Fri Sep 30 04:39:29 2022 -0400 linting. fix merge error. commit 302320d Author: Erick Winston <[email protected]> Date: Fri Sep 30 04:32:39 2022 -0400 merged main and renabled checkmap tests commit 8ec9259 Merge: cb32908 3c9d8d5 Author: Erick Winston <[email protected]> Date: Fri Sep 30 04:14:53 2022 -0400 Merge branch 'main' into controlflow/stochastic_swap commit cb32908 Author: Erick Winston <[email protected]> Date: Fri Sep 30 02:28:01 2022 -0400 updated to allow cf blocks with different registers than containing circuit. commit fb0496e Author: Erick Winston <[email protected]> Date: Thu Sep 29 15:38:28 2022 -0400 fix while loop test commit 463a466 Author: Erick Winston <[email protected]> Date: Wed Sep 28 14:26:14 2022 -0400 simplify dadnode handling of swap and cz commit 4f1af5b Author: Erick Winston <[email protected]> Date: Thu Sep 8 13:16:15 2022 -0400 remove merge artifact commit 3133949 Merge: 3c85677 53231fb Author: Erick Winston <[email protected]> Date: Thu Sep 8 13:15:18 2022 -0400 Merge branch 'test_merge' into controlflow/stochastic_swap commit 53231fb Author: Erick Winston <[email protected]> Date: Thu Sep 8 12:24:55 2022 -0400 remove redefiing coupling map in control flow context commit 0161913 Author: Erick Winston <[email protected]> Date: Wed Jul 20 09:56:28 2022 -0400 add controlflow handling to stochastic swap pass commit 072c550 Author: Junye Huang <[email protected]> Date: Thu Sep 8 14:22:12 2022 +0200 Add common usage explanations and code examples to qiskit.visualization module API page (Qiskit#8569) * add draft * revert unintended changes * revert unintended changes * add example usage * add common keyword arguments section * add sections to apis * fix internal links * remove generated hist figure * lint * use matplotlib instead of Matplotlib in class reference * change to a valid denisty matrix in examples * import from qiskit.visualization instead of qiskit.tools.visualization * remove unintended changes * split counts and state visualizations * remove overview and prerequisite headings * move common kwargs sections to the top level * remove link to api table * remove apis headings * remove extra blank lines * remove extra blank lines * minor twig on the counts to make them 1000 shots in total * add an intro sentence before the example for common kwargs Co-authored-by: Luciano Bello <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> commit 64bbeff Author: Takashi Imamichi <[email protected]> Date: Thu Sep 8 19:38:53 2022 +0900 Add an error check for Sampler (Qiskit#8678) * add an error check for sampler * update * Update qiskit/primitives/base_sampler.py Co-authored-by: Julien Gacon <[email protected]> * remove a duplicate check * update an error messgage Co-authored-by: Julien Gacon <[email protected]> commit bb41815 Author: Luciano Bello <[email protected]> Date: Thu Sep 8 00:52:46 2022 +0200 Remove deprecated pulse-builder contexts (Qiskit#8697) * Remove qiskit.pulse.builder.inline as deprecated in 0.18.0 (2021-07-13) * remove imports * remove test * Remove qiskit.pulse.builder.pad as deprecated in 0.18.0 (2021-07-13) * reno * Reword removal note Co-authored-by: Jake Lishman <[email protected]> commit ee0a4f1 Author: Manoel Marques <[email protected]> Date: Wed Sep 7 14:35:47 2022 -0400 Improve HHL/Shor deprecated messages (Qiskit#8699) commit ea4ebed Author: a-matsuo <[email protected]> Date: Wed Sep 7 17:33:53 2022 +0900 Include primitive's run_options (Qiskit#8694) * include primitive's run_options * rename to get_local_run_options commit a842f40 Author: Edwin Navarro <[email protected]> Date: Tue Sep 6 18:12:00 2022 -0700 Move circuit drawer files to `qiskit.visualization.circuit` (Qiskit#8306) * Add graph and circuit dirs * Move files to new folders * Finishing transition to circuit and graph dirs * Finish import changes * Positioning files and setting init entries * Final tweaks to compatibility and lint * Reduce to circuit dir only * Cleanup * Add qcstyle stub for docs * Merge main conflicts fix * Lint * Change test message * Fix _directive change * Fix op.condition reference * Change to _utils and cleanup * Lint * Fix _trim and dag_drawer test * Allow direct import of text, etc. * Add comment explaining backwards-compatibility imports * Add release note Co-authored-by: Jake Lishman <[email protected]> commit f4a5241 Author: Ikko Hamamura <[email protected]> Date: Tue Sep 6 00:37:43 2022 +0900 Default run_options for Primitives (Qiskit#8513) * Add run_options to Primitives * rm unnecessary comments * initial commit of Settings dataclass * Revert "initial commit of Settings dataclass" This reverts commit 96b8479. * fix lint, improve docs, don't return self Co-authored-by: Julien Gacon <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> commit a8e553c Author: a-matsuo <[email protected]> Date: Mon Sep 5 21:05:35 2022 +0900 Gradients with the primitives (Qiskit#8528) * added the gradients with the primitives Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]> * add run_options and supported gate Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]> * added unittests Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]> * lint Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]> * fix based on the comments Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]> * fix Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]> * add spsa gradient Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]> * simplify + async Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]> * added gradient variance Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]> * lint Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]> * added the run_options field Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]> * fix lint Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]> * fix based on comments Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]> * wip fix2 Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]> * fix Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]> * lint Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]> * fix epsilon and doc * lint Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]> * fix * Update qiskit/algorithms/gradients/base_sampler_gradient.py Co-authored-by: Takashi Imamichi <[email protected]> * Update qiskit/algorithms/gradients/base_sampler_gradient.py Co-authored-by: Takashi Imamichi <[email protected]> * Update qiskit/algorithms/gradients/base_estimator_gradient.py Co-authored-by: Takashi Imamichi <[email protected]> * Update qiskit/algorithms/gradients/base_sampler_gradient.py Co-authored-by: Takashi Imamichi <[email protected]> * Update qiskit/algorithms/gradients/base_estimator_gradient.py Co-authored-by: Takashi Imamichi <[email protected]> * Update qiskit/algorithms/gradients/base_estimator_gradient.py Co-authored-by: Takashi Imamichi <[email protected]> * change epsilon error Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]> * Update qiskit/algorithms/gradients/estimator_gradient_result.py Co-authored-by: Takashi Imamichi <[email protected]> * Update qiskit/algorithms/gradients/sampler_gradient_result.py Co-authored-by: Takashi Imamichi <[email protected]> * add gradient test * added batch size in spsa gradients Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]> * fix Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]> * lint * Update qiskit/algorithms/gradients/lin_comb_estimator_gradient.py Co-authored-by: Julien Gacon <[email protected]> * add operator tests Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]> * consistent name * rewrite spsa Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]> * use algorithm job Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]> Co-authored-by: Julien Gacon <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]> commit 879f7ba Author: dalin27 <[email protected]> Date: Mon Sep 5 05:02:11 2022 +0300 fixed issue 8670 by inverting qubits_coordinates and coupling_map (Qiskit#8671) commit 3c85677 Merge: 33e0007 e9913e8 Author: Erick Winston <[email protected]> Date: Thu Sep 8 12:30:39 2022 -0400 Merge branch 'main' into controlflow/stochastic_swap commit 33e0007 Author: Erick Winston <[email protected]> Date: Thu Sep 8 12:24:55 2022 -0400 remove redefiing coupling map in control flow context commit cd9c5cf Merge: ca4f477 aca01eb Author: ewinston <[email protected]> Date: Sat Sep 3 02:15:59 2022 -0400 Merge branch 'main' into controlflow/stochastic_swap commit ca4f477 Author: Erick Winston <[email protected]> Date: Fri Sep 2 16:15:08 2022 -0400 remove breakpoint commit ee78880 Author: Erick Winston <[email protected]> Date: Fri Sep 2 16:13:38 2022 -0400 fix check_map commit ef35278 Author: Erick Winston <[email protected]> Date: Fri Sep 2 01:13:12 2022 -0400 add check_map to tests. tests passing commit 349dca4 Author: Erick Winston <[email protected]> Date: Thu Sep 1 11:29:47 2022 -0400 add check_map commit cb1398d Author: Erick Winston <[email protected]> Date: Wed Aug 31 22:29:37 2022 -0400 convert up to for loop commit 3169afd Author: Erick Winston <[email protected]> Date: Tue Aug 30 15:54:53 2022 -0400 lint commit 2b8d5bb Author: Erick Winston <[email protected]> Date: Mon Aug 29 16:02:12 2022 -0400 rmove `continue` handling. raise error on unsupported control flow op. commit 12fb4bc Author: Erick Winston <[email protected]> Date: Mon Aug 29 15:55:44 2022 -0400 remove DAGCircuit.control_flow_ops commit 9a0ad5c Merge: 09f8490 82e38d1 Author: ewinston <[email protected]> Date: Fri Aug 12 10:46:41 2022 -0400 Merge branch 'main' into controlflow/stochastic_swap commit 09f8490 Author: Erick Winston <[email protected]> Date: Wed Jul 20 09:56:28 2022 -0400 add controlflow handling to stochastic swap pass

* added the gradients with the primitives Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]> * add run_options and supported gate Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]> * added unittests Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]> * lint Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]> * fix based on the comments Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]> * fix Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]> * add spsa gradient Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]> * simplify + async Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]> * added gradient variance Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]> * lint Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]> * added the run_options field Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]> * fix lint Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]> * fix based on comments Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]> * wip fix2 Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]> * fix Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]> * lint Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]> * fix epsilon and doc * lint Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]> * fix * Update qiskit/algorithms/gradients/base_sampler_gradient.py Co-authored-by: Takashi Imamichi <[email protected]> * Update qiskit/algorithms/gradients/base_sampler_gradient.py Co-authored-by: Takashi Imamichi <[email protected]> * Update qiskit/algorithms/gradients/base_estimator_gradient.py Co-authored-by: Takashi Imamichi <[email protected]> * Update qiskit/algorithms/gradients/base_sampler_gradient.py Co-authored-by: Takashi Imamichi <[email protected]> * Update qiskit/algorithms/gradients/base_estimator_gradient.py Co-authored-by: Takashi Imamichi <[email protected]> * Update qiskit/algorithms/gradients/base_estimator_gradient.py Co-authored-by: Takashi Imamichi <[email protected]> * change epsilon error Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]> * Update qiskit/algorithms/gradients/estimator_gradient_result.py Co-authored-by: Takashi Imamichi <[email protected]> * Update qiskit/algorithms/gradients/sampler_gradient_result.py Co-authored-by: Takashi Imamichi <[email protected]> * add gradient test * added batch size in spsa gradients Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]> * fix Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]> * lint * Update qiskit/algorithms/gradients/lin_comb_estimator_gradient.py Co-authored-by: Julien Gacon <[email protected]> * add operator tests Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]> * consistent name * rewrite spsa Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]> * use algorithm job Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]> Co-authored-by: Julien Gacon <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]>

added the gradients with the primitives

72d7c25

Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]>

Merge branch 'main' into gradients-primitives

f97b218

a-matsuo and others added 2 commits August 16, 2022 20:19

add run_options and supported gate

ad81449

Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]>

Merge branch 'gradients-primitives' of github.com:a-matsuo/qiskit-ter…

c1423bb

…ra into gradients-primitives

ElePT reviewed Aug 17, 2022

View reviewed changes

qiskit/algorithms/gradients/finite_diff_estimator_gradient.py Outdated Show resolved Hide resolved

added unittests

7ee8f28

Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]>

a-matsuo force-pushed the gradients-primitives branch from 16fc18d to 7ee8f28 Compare August 22, 2022 12:53

a-matsuo and others added 2 commits August 22, 2022 21:57

Merge remote-tracking branch 'upstream/main' into gradients-primitives

9454075

lint

b7ad4aa

Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]>

a-matsuo changed the title ~~[WIP] Gradients with the primitives~~ Gradients with the primitives Aug 22, 2022

a-matsuo marked this pull request as ready for review August 22, 2022 16:32

a-matsuo requested review from a team, manoelmarques and woodsp-ibm as code owners August 22, 2022 16:32

Merge branch 'main' into gradients-primitives

f918a2a

ikkoham reviewed Aug 23, 2022

View reviewed changes

qiskit/algorithms/gradients/base_estimator_gradient.py Outdated Show resolved Hide resolved

qiskit/algorithms/gradients/base_estimator_gradient.py Outdated Show resolved Hide resolved

qiskit/algorithms/gradients/estimator_gradient_result.py Outdated Show resolved Hide resolved

t-imamichi reviewed Aug 23, 2022

View reviewed changes

qiskit/algorithms/gradients/__init__.py Outdated Show resolved Hide resolved

t-imamichi reviewed Aug 23, 2022

View reviewed changes

qiskit/algorithms/gradients/sampler_gradient_result.py Outdated Show resolved Hide resolved

ElePT reviewed Aug 23, 2022

View reviewed changes

qiskit/algorithms/gradients/base_estimator_gradient.py Outdated Show resolved Hide resolved

qiskit/algorithms/gradients/finite_diff_estimator_gradient.py Outdated Show resolved Hide resolved

ElePT reviewed Aug 23, 2022

View reviewed changes

qiskit/algorithms/gradients/base_sampler_gradient.py Show resolved Hide resolved

woodsp-ibm reviewed Aug 23, 2022

View reviewed changes

qiskit/algorithms/gradients/base_estimator_gradient.py Outdated Show resolved Hide resolved

woodsp-ibm reviewed Aug 23, 2022

View reviewed changes

qiskit/algorithms/gradients/base_estimator_gradient.py Outdated Show resolved Hide resolved

a-matsuo and others added 3 commits August 24, 2022 10:39

fix based on the comments

9ebe3ef

Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]>

fix

aeb76ff

Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]>

add spsa gradient

f19222d

Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]>

a-matsuo force-pushed the gradients-primitives branch from 876e50e to f19222d Compare August 24, 2022 08:23

Cryoris reviewed Aug 24, 2022

View reviewed changes

simplify + async

8c63899

Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]>

a-matsuo and others added 4 commits September 2, 2022 11:32

Merge pull request #12 from t-imamichi/grad-test

22cf235

add gradient test

Merge remote-tracking branch 'upstream/main' into gradients-primitives

b8b98fa

lint

9242360

Merge branch 'main' into gradients-primitives

5b40c6f

Cryoris reviewed Sep 2, 2022

View reviewed changes

qiskit/algorithms/gradients/lin_comb_estimator_gradient.py Outdated Show resolved Hide resolved

Update qiskit/algorithms/gradients/lin_comb_estimator_gradient.py

f8a45b0

Co-authored-by: Julien Gacon <[email protected]>

Cryoris reviewed Sep 2, 2022

View reviewed changes

qiskit/algorithms/gradients/spsa_estimator_gradient.py Outdated Show resolved Hide resolved

Cryoris reviewed Sep 2, 2022

View reviewed changes

qiskit/algorithms/gradients/spsa_sampler_gradient.py Outdated Show resolved Hide resolved

Cryoris reviewed Sep 2, 2022

View reviewed changes

test/python/algorithms/test_estimator_gradient.py Show resolved Hide resolved

a-matsuo and others added 4 commits September 2, 2022 16:48

add operator tests

c17b53d

Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]>

Merge branch 'gradients-primitives' of github.com:a-matsuo/qiskit-ter…

044089b

…ra into gradients-primitives

consistent name

5957422

rewrite spsa

dd960a0

Co-authored-by: Ikko Hamamura <[email protected]> Co-authored-by: Takashi Imamichi <[email protected]>