Pin setuptools in CI #8526
Merged
Pin setuptools in CI #8526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recently released setuptools 64.0.0 release introduced a regression that prevents editable installs from working (see pypa/setuptools#3498). This is blocking CI as we use editable installs to build and install terra for testing. When there is an upstream release fixing this issue we can remove the pins.
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
|
|
|
@agroszer thanks, I'll give that a try now. I was just trying to avoid needing that in the hope a downgrade/pin would be sufficient. I'm not sure what is causing the previous release to fail now. |
|
went down the same rabbithole |
Pull Request Test Coverage Report for Build 2842621297
💛 - Coveralls |
mtreinish
added
type: qa
Cryoris
approved these changes
Aug 12, 2022
|
setuptools 64.0.1 fixes this |
mtreinish
added a commit
to mtreinish/qiskit-core
that referenced
this pull request
Aug 12, 2022
With the release of setuptools 64.0.1 the issues previously blocking CI and editable installs more generally should have fixed now. This commit reverts the pins previously introduced to unblock CI and work around the broken release. This reverts commit 82e38d1.
mtreinish
added
the
stable backport potential
mergify bot
pushed a commit
that referenced
this pull request
Aug 16, 2022
* Pin setuptools in CI The recently released setuptools 64.0.0 release introduced a regression that prevents editable installs from working (see pypa/setuptools#3498). This is blocking CI as we use editable installs to build and install terra for testing. When there is an upstream release fixing this issue we can remove the pins. * Remove pip/setuptools/wheel manual install step * Try venv instead of virtualenv * Revert "Try venv instead of virtualenv" This reverts commit 3ada819. * Revert "Remove pip/setuptools/wheel manual install step" This reverts commit 831bc6e. * Pin in constraints.txt too * Lower version further * Pin setuptools-rust too * Set editable install to legacy mode via env var * Set env variable correctly everywhere we build terra * Add missing env variable setting for image tests (cherry picked from commit 82e38d1)
mergify bot
added a commit
that referenced
this pull request
Aug 16, 2022
* Pin setuptools in CI The recently released setuptools 64.0.0 release introduced a regression that prevents editable installs from working (see pypa/setuptools#3498). This is blocking CI as we use editable installs to build and install terra for testing. When there is an upstream release fixing this issue we can remove the pins. * Remove pip/setuptools/wheel manual install step * Try venv instead of virtualenv * Revert "Try venv instead of virtualenv" This reverts commit 3ada819. * Revert "Remove pip/setuptools/wheel manual install step" This reverts commit 831bc6e. * Pin in constraints.txt too * Lower version further * Pin setuptools-rust too * Set editable install to legacy mode via env var * Set env variable correctly everywhere we build terra * Add missing env variable setting for image tests (cherry picked from commit 82e38d1) Co-authored-by: Matthew Treinish <[email protected]>
mergify bot
added a commit
that referenced
this pull request
Aug 22, 2022
* Revert "Pin setuptools in CI (#8526)" With the release of setuptools 64.0.1 the issues previously blocking CI and editable installs more generally should have fixed now. This commit reverts the pins previously introduced to unblock CI and work around the broken release. This reverts commit 82e38d1. * Add back SETUPTOOLS_ENABLE_FEATURES env var for legacy editable install Co-authored-by: Jake Lishman <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
mergify bot
pushed a commit
that referenced
this pull request
Aug 22, 2022
* Revert "Pin setuptools in CI (#8526)" With the release of setuptools 64.0.1 the issues previously blocking CI and editable installs more generally should have fixed now. This commit reverts the pins previously introduced to unblock CI and work around the broken release. This reverts commit 82e38d1. * Add back SETUPTOOLS_ENABLE_FEATURES env var for legacy editable install Co-authored-by: Jake Lishman <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit dfca1fb)
mergify bot
added a commit
that referenced
this pull request
Aug 22, 2022
* Revert "Pin setuptools in CI (#8526)" With the release of setuptools 64.0.1 the issues previously blocking CI and editable installs more generally should have fixed now. This commit reverts the pins previously introduced to unblock CI and work around the broken release. This reverts commit 82e38d1. * Add back SETUPTOOLS_ENABLE_FEATURES env var for legacy editable install Co-authored-by: Jake Lishman <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit dfca1fb) Co-authored-by: Matthew Treinish <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The recently released setuptools 64.0.0 release introduced a regression
that prevents editable installs from working (see pypa/setuptools#3498).
This is blocking CI as we use editable installs to build and install
terra for testing. When there is an upstream release fixing this issue
we can remove the pins.
Details and comments