-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin setuptools in CI #8526
Pin setuptools in CI #8526
Conversation
The recently released setuptools 64.0.0 release introduced a regression that prevents editable installs from working (see pypa/setuptools#3498). This is blocking CI as we use editable installs to build and install terra for testing. When there is an upstream release fixing this issue we can remove the pins.
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
|
@agroszer thanks, I'll give that a try now. I was just trying to avoid needing that in the hope a downgrade/pin would be sufficient. I'm not sure what is causing the previous release to fail now. |
went down the same rabbithole |
Pull Request Test Coverage Report for Build 2842621297
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
setuptools 64.0.1 fixes this |
With the release of setuptools 64.0.1 the issues previously blocking CI and editable installs more generally should have fixed now. This commit reverts the pins previously introduced to unblock CI and work around the broken release. This reverts commit 82e38d1.
* Pin setuptools in CI The recently released setuptools 64.0.0 release introduced a regression that prevents editable installs from working (see pypa/setuptools#3498). This is blocking CI as we use editable installs to build and install terra for testing. When there is an upstream release fixing this issue we can remove the pins. * Remove pip/setuptools/wheel manual install step * Try venv instead of virtualenv * Revert "Try venv instead of virtualenv" This reverts commit 3ada819. * Revert "Remove pip/setuptools/wheel manual install step" This reverts commit 831bc6e. * Pin in constraints.txt too * Lower version further * Pin setuptools-rust too * Set editable install to legacy mode via env var * Set env variable correctly everywhere we build terra * Add missing env variable setting for image tests (cherry picked from commit 82e38d1)
* Pin setuptools in CI The recently released setuptools 64.0.0 release introduced a regression that prevents editable installs from working (see pypa/setuptools#3498). This is blocking CI as we use editable installs to build and install terra for testing. When there is an upstream release fixing this issue we can remove the pins. * Remove pip/setuptools/wheel manual install step * Try venv instead of virtualenv * Revert "Try venv instead of virtualenv" This reverts commit 3ada819. * Revert "Remove pip/setuptools/wheel manual install step" This reverts commit 831bc6e. * Pin in constraints.txt too * Lower version further * Pin setuptools-rust too * Set editable install to legacy mode via env var * Set env variable correctly everywhere we build terra * Add missing env variable setting for image tests (cherry picked from commit 82e38d1) Co-authored-by: Matthew Treinish <[email protected]>
* Revert "Pin setuptools in CI (#8526)" With the release of setuptools 64.0.1 the issues previously blocking CI and editable installs more generally should have fixed now. This commit reverts the pins previously introduced to unblock CI and work around the broken release. This reverts commit 82e38d1. * Add back SETUPTOOLS_ENABLE_FEATURES env var for legacy editable install Co-authored-by: Jake Lishman <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* Revert "Pin setuptools in CI (#8526)" With the release of setuptools 64.0.1 the issues previously blocking CI and editable installs more generally should have fixed now. This commit reverts the pins previously introduced to unblock CI and work around the broken release. This reverts commit 82e38d1. * Add back SETUPTOOLS_ENABLE_FEATURES env var for legacy editable install Co-authored-by: Jake Lishman <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit dfca1fb)
* Revert "Pin setuptools in CI (#8526)" With the release of setuptools 64.0.1 the issues previously blocking CI and editable installs more generally should have fixed now. This commit reverts the pins previously introduced to unblock CI and work around the broken release. This reverts commit 82e38d1. * Add back SETUPTOOLS_ENABLE_FEATURES env var for legacy editable install Co-authored-by: Jake Lishman <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit dfca1fb) Co-authored-by: Matthew Treinish <[email protected]>
Summary
The recently released setuptools 64.0.0 release introduced a regression
that prevents editable installs from working (see pypa/setuptools#3498).
This is blocking CI as we use editable installs to build and install
terra for testing. When there is an upstream release fixing this issue
we can remove the pins.
Details and comments