Revert "Fix QuantumCircuit.assign_parameters docstring (#6546)"
#6696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…)" This PR included a deprecation removal which was invalid as not enough time has passed. The deprecation occured in 0.17.0 which is not eligible for removal until the 0.19.0 release. This PR can be repropoposed after 0.18.0 is released and quickly merged into 0.19.0. This reverts commit 09f9c10.
|
Oh I thought our deprecation policy just requires a deprecation period of 3 months, do we also wait one release cycle? |
Not explicitly, but this release was originally targeted for a couple weeks ago and kept slipping. But, when we pushed it back the first time we decided to not open up the deprecation removals from 0.17.0 until 0.19.0. Believe me I'm eager too (see #6558) but it's better to be a bit more cautious on these things. |
kdk
approved these changes
Jul 7, 2021
mtreinish
added a commit
to mtreinish/qiskit-core
that referenced
this pull request
Jul 12, 2021
Right before the 0.18.0 release we reverted Qiskit#6546 because it was a bit too quick to complete a deprecation. Now that 0.18.0 has been released we can now remove the deprecated functionality and this commit reverts PR Qiskit#6696 which just re-applies Qiskit#6546. This reverts commit 1104041.
mergify bot
added a commit
that referenced
this pull request
Jul 13, 2021
* Fix ``QuantumCircuit.assign_parameters`` docstring Right before the 0.18.0 release we reverted #6546 because it was a bit too quick to complete a deprecation. Now that 0.18.0 has been released we can now remove the deprecated functionality and this commit reverts PR #6696 which just re-applies #6546. This reverts commit 1104041. * Update releasenotes/notes/remove-deprecated-assign-parameters-args-9712d7d01e82c390.yaml Co-authored-by: Julien Gacon <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR included a deprecation removal which was invalid as not enough
time has passed. The deprecation occured in 0.17.0 which is not eligible
for removal until the 0.19.0 release. This PR can be reproposed after
0.18.0 is released and quickly merged into 0.19.0.
Details and comments
This reverts commit 09f9c10.