Remove deepcopies from DAGCircuit.__eq__ #4992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The __eq__ method of the dagcircuit class was previously deep copying the retworkx PyDAG objects for both self and other to force a reindexing of the node indices in the graphs to acvoid a bug in retworkx (see Qiskit/rustworkx#27 for more details). In the next retworkx a workaround for that bug was introduced which removes the need for doing the deepcopy calls. This commit does that and removes the deep copies which should improve the performance of run __eq__ o dagcircuit objects.
|
Marking as on hold because retworkx 0.5.0 isn't ready yet |
|
I released retworkx 0.5.0 a few minutes ago so this is no longer blocked |
kdk
approved these changes
Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
__eq__method of the dagcircuit class was previously deep copyingthe retworkx PyDAG objects for both self and other to force a reindexing
of the node indices in the graphs to acvoid a bug in retworkx (see
Qiskit/rustworkx#27 for more details). In the next retworkx a workaround
for that bug was introduced which removes the need for doing the deepcopy
calls. This commit does that and removes the deep copies which should
improve the performance of run
__eq__on dagcircuit objects.Details and comments