New Visual Studio Solution for C++ Sim + some crash fixes

[Shark-y]

Added VS 2017 solution stuff
Fixed crash in WIN64 Clifford Sim(circuit.hpp)
Fixed crash in WIN64 Ideal Sim(vector_engine.hpp)

Created a Visual Studio 2017 solution for the C++ simulator and fixed 2 crashes I encountered along the way.

Description

• Added VS 2017 solution
• Fixed crash Setuptools Bootstrapper script is deprecated #1 in clifford sim (circuit.hpp)
• Fixed crash Behavior of the instruction "measure q[i] -> q[j];" #2 in ideal sim (vector_engine.hpp)

Motivation and Context

I wanted to run the C++ sim in windows but the default Python exe crashed + had no VS solution

How Has This Been Tested?

Tested in VS 2017 against the input files provided by the default Python SDk

Screenshots (if appropriate):

Types of changes

• [x ] Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• [x ] My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[nonhermitian]

A working VS build chain can also be found in #412. The difference being that the build is guided by setuptools, and uses VS 2015, as that is the compiler used to build Py35+, and is the only supported Python compilation method on Windows. It also builds against the BLAS used by NumPy. The #412 method also does not have the crashes you reported.

[atilag]

Hi @Shark-y fortunately we have moved to a CMake build system that will take care of building QISKit in any compiler users might have installed on their system. QISKit is meant to be compatible with all major platforms, so having specific configurations for every possible compiler would be crazy to maintain, this is actually one of the jobs of CMake so we don't need to worry.
As you already have a Visual Studio 2017 installed in your system, I was going to ask you if you could make it work with our CMake system, and create a PR with the changes!
If you are not familiar with CMake (I think you are, because I saw a CMakeLists.txt in your PR), I'll be more than glad to help you through the process!! ... is actually pretty simple, we already have all the tough parts in place ;)
You said you found a crash on windows, can you give us more details, like:

• Which version of Windows are you running (Vista/Win7/Win10 32/64 bits)?
• What did you do (step by step) to reproduce the error?

Thanks @Shark-y !

[atilag]

We have landed support (in master) for building QISKit with basically any flavor of VS (2017,2015,2102...), as well as MinGW (64 bits). We are linking with a our own build of OpenBLAS, so there's no need for any other .dll/.lib dependency. Anyway, we are evaluating the option of linking with other BLAS implementations like MKL.
Closing this issue, please feel free to re-open it if you consider so.