Fix .decompose on control flow (backport #13545)
#13549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* decompose control flow ops * add reno and test * trailing print * thou shall support Python 3.9 * Fix comments & reno Co-authored-by: Elena Peña Tapia <[email protected]> --------- Co-authored-by: Elena Peña Tapia <[email protected]> (cherry picked from commit 4495c67)
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the following people are relevant to this code:
|
github-actions
bot
added
the
Changelog: Bugfix
Cryoris
approved these changes
Dec 10, 2024
Pull Request Test Coverage Report for Build 12259875909Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes two behaviors when decomposing control flow:
c_ifon an operation without definition (i.e.None) would failQuantumCircuit.decomposeraises an error with a conditional U gate for Qiskit 1.3.0 and the main branch #13493).decompose(Control flow operations are not.decomposed #13544)Details and comments
Even though
c_ifis deprecated we should still handle this case, but the logic for this can be removed oncec_ifis gone. There's a comment specifying which part isc_if-specific.This is an automatic backport of pull request #13545 done by [Mergify](https://mergify.com).