Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CommutationChecker for comparison with rotation gates on angles $k\pi$ #13399

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

Cryoris
Copy link
Contributor

@Cryoris Cryoris commented Nov 5, 2024

Summary

In #13302 a mistake creeped in, accidentally stating that rotation gates commute for angles that are multiples of $\pi$ instead of $2\pi$. I would've expected this to break somewhere in the test suite, now explicit tests are added. No reno as this is not yet released.

@Cryoris Cryoris added this to the 1.3.0 milestone Nov 5, 2024
@Cryoris Cryoris requested a review from a team as a code owner November 5, 2024 20:35
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@mtreinish mtreinish added the Changelog: None Do not include in changelog label Nov 5, 2024
Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I'm surprised we didn't hit this anywhere during review of the PR. But good to catch this now.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11692110509

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 32 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-0.04%) to 88.761%

Files with Coverage Reduction New Missed Lines %
crates/accelerate/src/unitary_synthesis.rs 1 92.2%
crates/accelerate/src/two_qubit_decompose.rs 1 92.09%
qiskit/transpiler/passes/synthesis/unitary_synthesis.py 2 58.05%
crates/qasm2/src/lex.rs 3 91.98%
qiskit/synthesis/two_qubit/xx_decompose/decomposer.py 7 90.77%
crates/qasm2/src/parse.rs 18 95.77%
Totals Coverage Status
Change from base Build 11690680453: -0.04%
Covered Lines: 77026
Relevant Lines: 86779

💛 - Coveralls

@mtreinish mtreinish added this pull request to the merge queue Nov 5, 2024
Merged via the queue into Qiskit:main with commit c7ccbd4 Nov 5, 2024
19 checks passed
@Cryoris Cryoris deleted the fix-cc branch November 6, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog priority: high
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants