Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix qft-plugins for custom 'qft' gates (backport #13181) #13189

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 19, 2024

Summary

The HighLevelSynthesis transpiler pass no longer raises an exception when encountering a custom gate that is called "qft" but is not an instance of class QFTGate. Instead, the synthesis plugins for QFT gates ignore such a gate, and the gate's definition is used (if provided).

Fixes #13120 and #13174.

The PR is very short and has backport potential (if desired).


This is an automatic backport of pull request #13181 done by [Mergify](https://mergify.com).

@mergify mergify bot added the conflicts used by mergify when there are conflicts in a port label Sep 19, 2024
Copy link
Contributor Author

mergify bot commented Sep 19, 2024

Cherry-pick of 2245a4f has failed:

On branch mergify/bp/stable/1.2/pr-13181
Your branch is up to date with 'origin/stable/1.2'.

You are currently cherry-picking commit 2245a4f44.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   releasenotes/notes/fix-qft-plugins-7106029d33c44b96.yaml

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   qiskit/transpiler/passes/synthesis/hls_plugins.py
	both modified:   test/python/transpiler/test_high_level_synthesis.py

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@github-actions github-actions bot added the Changelog: Bugfix Include in the "Fixed" section of the changelog label Sep 19, 2024
@github-actions github-actions bot added this to the 1.2.2 milestone Sep 19, 2024
Copy link
Member

@jakelishman jakelishman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this passes lint/tests, it should now be a clean cherry-pick.

@jakelishman jakelishman removed the conflicts used by mergify when there are conflicts in a port label Sep 19, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10945733297

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 17 unchanged lines in 2 files lost coverage.
  • Overall coverage remained the same at 89.758%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 5 91.73%
crates/qasm2/src/parse.rs 12 97.15%
Totals Coverage Status
Change from base Build 10938909061: 0.0%
Covered Lines: 66873
Relevant Lines: 74504

💛 - Coveralls

@jakelishman jakelishman added this pull request to the merge queue Sep 19, 2024
github-merge-queue bot pushed a commit that referenced this pull request Sep 19, 2024
(cherry picked from commit 2245a4f)

Co-authored-by: Jake Lishman <[email protected]>
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Sep 19, 2024
@jakelishman jakelishman added this pull request to the merge queue Sep 19, 2024
Merged via the queue into stable/1.2 with commit cc0fc75 Sep 19, 2024
17 checks passed
@mtreinish mtreinish deleted the mergify/bp/stable/1.2/pr-13181 branch September 20, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants