Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean two_qubit_decompose code #13093

Merged
merged 10 commits into from
Sep 13, 2024
Merged

Conversation

ShellyGarion
Copy link
Member

@ShellyGarion ShellyGarion commented Sep 5, 2024

Summary

In this PR we remove some unused code from the file qiskit/synthesis/two_qubit/two_qubit_decompose.py.
And moreover, the following Python functions now calls the relevant Rust functions:

  • decompose_two_qubit_product_gate
  • trace_to_fid
  • Ud

Details and comments

@ShellyGarion ShellyGarion added synthesis Rust This PR or issue is related to Rust code in the repository labels Sep 5, 2024
@ShellyGarion ShellyGarion added this to the 1.3 beta milestone Sep 5, 2024
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core
  • @kevinhartman
  • @levbishop
  • @mtreinish

@coveralls
Copy link

coveralls commented Sep 5, 2024

Pull Request Test Coverage Report for Build 10806927953

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 57 of 58 (98.28%) changed or added relevant lines in 2 files are covered.
  • 795 unchanged lines in 31 files lost coverage.
  • Overall coverage decreased (-0.3%) to 88.859%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit/synthesis/two_qubit/two_qubit_decompose.py 2 3 66.67%
Files with Coverage Reduction New Missed Lines %
qiskit/quantum_info/operators/mixins/multiply.py 1 93.75%
qiskit/synthesis/one_qubit/one_qubit_decompose.py 1 70.67%
qiskit/quantum_info/operators/mixins/group.py 1 92.59%
qiskit/transpiler/passes/synthesis/unitary_synthesis.py 1 88.26%
crates/qasm2/src/expr.rs 1 94.02%
qiskit/quantum_info/operators/channel/quantum_channel.py 1 72.14%
qiskit/quantum_info/operators/mixins/adjoint.py 1 90.0%
qiskit/quantum_info/operators/mixins/linear.py 1 88.0%
crates/accelerate/src/synthesis/clifford/utils.rs 1 78.06%
qiskit/visualization/circuit/_utils.py 2 94.25%
Totals Coverage Status
Change from base Build 10721003464: -0.3%
Covered Lines: 73114
Relevant Lines: 82281

💛 - Coveralls

Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, thanks for doing this. I have two small nits inline but otherwise I think this is good to go.

crates/accelerate/src/two_qubit_decompose.rs Outdated Show resolved Hide resolved
crates/accelerate/src/two_qubit_decompose.rs Outdated Show resolved Hide resolved
Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, just one inline question/suggestion otherwise I think this is good to go.

crates/accelerate/src/two_qubit_decompose.rs Outdated Show resolved Hide resolved
@mtreinish mtreinish modified the milestones: 1.3 beta, 1.3.0 Sep 11, 2024
@mtreinish mtreinish added the Changelog: None Do not include in changelog label Sep 13, 2024
Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for updating.

@mtreinish mtreinish added this pull request to the merge queue Sep 13, 2024
Merged via the queue into Qiskit:main with commit 653b5b6 Sep 13, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog Rust This PR or issue is related to Rust code in the repository synthesis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants