-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean two_qubit_decompose code #13093
Conversation
One or more of the following people are relevant to this code:
|
Pull Request Test Coverage Report for Build 10806927953Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, thanks for doing this. I have two small nits inline but otherwise I think this is good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, just one inline question/suggestion otherwise I think this is good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for updating.
Summary
In this PR we remove some unused code from the file
qiskit/synthesis/two_qubit/two_qubit_decompose.py
.And moreover, the following Python functions now calls the relevant Rust functions:
decompose_two_qubit_product_gate
trace_to_fid
Ud
Details and comments