Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use of node.op in Split2QUnitaries #13015

Merged
merged 3 commits into from
Aug 30, 2024
Merged

Conversation

ElePT
Copy link
Contributor

@ElePT ElePT commented Aug 22, 2024

Summary

I believe this PR addresses the first point from #12970 but doesn't fully close the issue, there is still some digging to do in the pipeline.

Details and comments

@ElePT ElePT added this to the 1.2.1 milestone Aug 22, 2024
@ElePT ElePT added stable backport potential The bug might be minimal and/or import enough to be port to stable Changelog: Bugfix Include in the "Fixed" section of the changelog labels Aug 22, 2024
@coveralls
Copy link

coveralls commented Aug 22, 2024

Pull Request Test Coverage Report for Build 10556471677

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 562 unchanged lines in 28 files lost coverage.
  • Overall coverage decreased (-0.4%) to 89.225%

Files with Coverage Reduction New Missed Lines %
qiskit/transpiler/passes/optimization/optimize_1q_decomposition.py 1 96.88%
qiskit/providers/backend_compat.py 1 89.19%
qiskit/transpiler/passes/basis/unroll_3q_or_more.py 1 94.44%
qiskit/transpiler/passes/optimization/split_2q_unitaries.py 2 93.75%
qiskit/circuit/instruction.py 2 95.27%
qiskit/transpiler/passes/basis/unroll_custom_definitions.py 2 93.33%
crates/circuit/src/imports.rs 3 77.78%
crates/circuit/src/bit_data.rs 4 94.21%
qiskit/synthesis/two_qubit/two_qubit_decompose.py 4 93.51%
qiskit/transpiler/passes/scheduling/padding/dynamical_decoupling.py 4 94.94%
Totals Coverage Status
Change from base Build 10506699788: -0.4%
Covered Lines: 71635
Relevant Lines: 80286

💛 - Coveralls

@ElePT ElePT marked this pull request as ready for review August 26, 2024 08:35
@ElePT ElePT requested a review from a team as a code owner August 26, 2024 08:35
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@mtreinish mtreinish added this pull request to the merge queue Aug 30, 2024
Merged via the queue into Qiskit:main with commit 623415c Aug 30, 2024
15 checks passed
mergify bot pushed a commit that referenced this pull request Aug 30, 2024
* Replace node.op with node.matrix

* Add docstring to test gate

* Fix black

(cherry picked from commit 623415c)
github-merge-queue bot pushed a commit that referenced this pull request Aug 30, 2024
* Fix  use of `node.op` in `Split2QUnitaries` (#13015)

* Replace node.op with node.matrix

* Add docstring to test gate

* Fix black

(cherry picked from commit 623415c)

* Update test/python/transpiler/test_split_2q_unitaries.py

---------

Co-authored-by: Elena Peña Tapia <[email protected]>
Co-authored-by: Matthew Treinish <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants