adding copy argument to QFTGate.__array__ #12979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderivrii
added
the
Changelog: Bugfix
|
One or more of the following people are relevant to this code:
|
ElePT
approved these changes
Aug 19, 2024
There was a problem hiding this comment.
Thanks a lot @alexanderivrii! I added a tiny suggestion but the PR can also be merged as-is, given that this bug is becoming annoying in the merge queue.
| """Return a numpy array for the QFTGate.""" | ||
| if copy is False: | ||
| raise ValueError("unable to avoid copy while creating an array as requested") |
There was a problem hiding this comment.
Tiny tiny suggestion:
Suggested change
| raise ValueError("unable to avoid copy while creating an array as requested") | |
| raise ValueError("Unable to avoid copy while creating an array as requested") |
There was a problem hiding this comment.
Thanks @ElePT! I agree that the capitalized "U" looks better, but all the other 30+ identical message use lower-case "u".
There was a problem hiding this comment.
hah, tunnel vision. Let's keep it consistent then.
|
The QFT gate was added in 1.2, right? (#11463) In that case we should also backport the fix. |
ElePT
added
the
stable backport potential
Pull Request Test Coverage Report for Build 10450381480Details
💛 - Coveralls |
This was referenced Aug 19, 2024
mergify bot
pushed a commit
that referenced
this pull request
Aug 19, 2024
(cherry picked from commit 06392c5)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 20, 2024
(cherry picked from commit 06392c5) Co-authored-by: Alexander Ivrii <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes numpy support for QFTGate: the QFT gate PR was developed in parallel with #11999 and did not get the required upgrade.