Improve error message on bad OpenQASM 3 basis_gates argument
#12945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the user requests a basis-gate name that cannot be used (like a keyword), there is nothing sensible we can output for a circuit that contains one of those operations. The exporter was already correctly erroring in these cases, but the error message was quite opaque.
jakelishman
added
stable backport potential
|
One or more of the following people are relevant to this code:
|
Pull Request Test Coverage Report for Build 10351808315Details
💛 - Coveralls |
Cryoris
approved these changes
Aug 12, 2024
|
@Mergifyio backport stable/1.2 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Aug 12, 2024
If the user requests a basis-gate name that cannot be used (like a keyword), there is nothing sensible we can output for a circuit that contains one of those operations. The exporter was already correctly erroring in these cases, but the error message was quite opaque. (cherry picked from commit fb9c0db)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 12, 2024
… (#12946) If the user requests a basis-gate name that cannot be used (like a keyword), there is nothing sensible we can output for a circuit that contains one of those operations. The exporter was already correctly erroring in these cases, but the error message was quite opaque. (cherry picked from commit fb9c0db) Co-authored-by: Jake Lishman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If the user requests a basis-gate name that cannot be used (like a keyword), there is nothing sensible we can output for a circuit that contains one of those operations. The exporter was already correctly erroring in these cases, but the error message was quite opaque.
Details and comments
Fix #12886