Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding info on how to add a rust module to qiskit and make it available from within python #12852

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

sbrandhsn
Copy link
Contributor

Summary

Details and comments

@sbrandhsn sbrandhsn requested a review from a team as a code owner July 30, 2024 11:58
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@coveralls
Copy link

coveralls commented Jul 30, 2024

Pull Request Test Coverage Report for Build 10307442049

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 824 unchanged lines in 45 files lost coverage.
  • Overall coverage increased (+0.002%) to 89.747%

Files with Coverage Reduction New Missed Lines %
qiskit/compiler/transpiler.py 1 92.39%
qiskit/primitives/backend_sampler.py 1 98.86%
qiskit/primitives/statevector_sampler.py 1 99.08%
qiskit/primitives/backend_estimator_v2.py 2 98.29%
qiskit/providers/backend_compat.py 2 89.73%
qiskit/providers/fake_provider/fake_qasm_backend.py 2 95.56%
crates/accelerate/src/sabre/layout.rs 2 90.21%
qiskit/utils/deprecation.py 3 97.79%
qiskit/providers/models/backendproperties.py 3 95.36%
qiskit/primitives/statevector_estimator.py 3 94.44%
Totals Coverage Status
Change from base Build 10161705193: 0.002%
Covered Lines: 67373
Relevant Lines: 75070

💛 - Coveralls

Copy link
Contributor

@raynelfss raynelfss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As someone who's had to figure out the ever changing ways of adding a PyO3 module to Qiskit, this is a much needed change. Thank you for working on this :)

I added a couple of comments about how to make this look a bit more readable and newcomer friendly, since it's mostly formatting nitpicks, I will leave them in comments for you to consider.

crates/accelerate/README.md Outdated Show resolved Hide resolved
crates/accelerate/README.md Outdated Show resolved Hide resolved
crates/accelerate/README.md Outdated Show resolved Hide resolved
@sbrandhsn
Copy link
Contributor Author

Looks great, thanks for the feedback! :-)

raynelfss
raynelfss previously approved these changes Aug 8, 2024
Copy link
Contributor

@raynelfss raynelfss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! However, I will not merge until @jakelishman takes a look, to see if this is explicit enough.

Copy link
Member

@jakelishman jakelishman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! It might help to drop a link to the relevant page of the PyO3 guide as well, so people can look in more detail.

crates/accelerate/README.md Outdated Show resolved Hide resolved
crates/accelerate/README.md Outdated Show resolved Hide resolved
@sbrandhsn
Copy link
Contributor Author

Thanks for your feedback, I incorporated it in the latest commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants