-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding info on how to add a rust module to qiskit and make it available from within python #12852
base: main
Are you sure you want to change the base?
Conversation
One or more of the following people are relevant to this code:
|
Pull Request Test Coverage Report for Build 10307442049Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As someone who's had to figure out the ever changing ways of adding a PyO3 module to Qiskit, this is a much needed change. Thank you for working on this :)
I added a couple of comments about how to make this look a bit more readable and newcomer friendly, since it's mostly formatting nitpicks, I will leave them in comments for you to consider.
Co-authored-by: Raynel Sanchez <[email protected]>
Looks great, thanks for the feedback! :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! However, I will not merge until @jakelishman takes a look, to see if this is explicit enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! It might help to drop a link to the relevant page of the PyO3 guide as well, so people can look in more detail.
Thanks for your feedback, I incorporated it in the latest commit. |
Summary
Details and comments