Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate fake backends based on BackendV1 (backport #12660) #12837

Merged
merged 3 commits into from
Jul 29, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 29, 2024

Branches from 1ucian0:deprecate/qobj_assemble/1 #12649, so blocked on that

Summary

Some of the introduced TODOs are waiting for fixes:


This is an automatic backport of pull request #12660 done by [Mergify](https://mergify.com).

* deprecate qobj and assemble

* reno

* first attempt on Fake1QV2

* deprecate Fake1Q

* Fake1QV2 should not have two-qubit gates

Co-authored-by: Elena Peña Tapia <[email protected]>

* test.python.circuit.test_parameters.TestParameters

* test.python.providers.fake_provider.test_fake_backends.FakeBackendsTest

* test.python.providers.test_fake_backends.TestFakeBackends

* test.python.result.test_mitigators

* test.python.transpiler.test_preset_passmanagers

* test.python.transpiler.test_target

* test.python.transpiler.test_unitary_synthesis

* test.python.transpiler.test_vf2_layout

* test.python.transpiler.test_vf2_post_layout

* test/python/visualization/test_circuit_latex

* test.python.transpiler.test_sabre_layout

* test.python.transpiler.test_sabre_layout

* test.python.transpiler.test_pulse_gate_pass

* test.python.scheduler.test_basic_scheduler.TestBasicSchedule

* test.python.pulse.test_transforms

* test.python.pulse.test_schedule

* test.python.pulse.test_macros

* test.python.pulse.test_instruction_schedule_map

* test.python.pulse.test_block

* test.python.circuit.test_scheduled_circuit

* test.python.transpiler.test_calibrationbuilder

* test.python.providers.test_backendconfiguration

* test.python.compiler.test_transpiler

* test.python.transpiler.test_passmanager_run

* test.python.transpiler.test_passmanager_config.TestPassManagerConfig.test_from_backend_and_user

* test.python.transpiler.test_passmanager_config

* test.python.primitives.test_backend_estimator.TestBackendEstimator

* test.python.circuit.test_scheduled_circuit.TestScheduledCircuit.test_schedule_circuit_when_backend_tells_dt

* test.python.circuit.test_scheduled_circuit

* test.python.transpiler.test_vf2_layout

* shallow deprecation of assemble

* test.python.compiler.test_disassembler

* fakebackend pulse

* test.python.circuit.test_parameters

* PulseQobjInstruction  is used by GenericBackendV2

* test.python.scheduler.test_basic_scheduler

* test.python.result.test_result

* test.python.pulse.test_calibration_entries

* test.python.compiler.test_assembler

* test.python.transpiler.test_star_prerouting

* test.python.pulse.test_instruction_schedule_map

* test.python.providers.basic_provider.test_basic_simulator

* test.python.primitives.test_backend_sampler_v2

* test.python.compiler.test_disassembler

* test.python.compiler.test_compiler

* test.python.circuit.test_scheduled_circuit

* test.python.providers.test_fake_backends

* test.python.circuit.test_unitary

* test.python.transpiler.test_sabre_swap

* test.python.providers.fake_provider.test_fake_backends

* Aer using Provider ABC

* aer warnings

* reno

* another pass on reno

* test.python.pulse

* test.python.compiler.test_compiler

* add module to fiterwarning

* test.python.compiler.test_transpiler

* fixing obscure expcetion handleing for comparison

* test.python.transpiler.test_stochastic_swap test.python.transpiler.test_sabre_swap

* test.python.transpiler.test_echo_rzx_weyl_decomposition

* test.python.transpiler.test_instruction_durations

* test.python.providers.test_backendproperties

* test.python.qpy.test_circuit_load_from_qpy

* test.python.providers.test_pulse_defaults

* test.python.primitives.test_backend_sampler_v2

* test.python.primitives.test_backend_sampler

* test.python.compiler.test_scheduler

* test/python/compiler/test_scheduler.py

* test.python.compiler.test_disassembler

* test.python.compiler.test_assembler

* test.python.compiler.test_sequencer

* test.python.compiler.test_transpiler

* test.python.primitives.test_primitive

* better depreaction handleling from Aer

* test.python.primitives.test_backend_estimator_v2

* test.python.compiler.test_compiler

* ignore warnings, because the output is otherwise very verbose

* ignore to avoid fludding the CI log

* seeding all GenericBackendV2

* test.python.visualization.test_gate_map

* deprecation warnings: once

* default

* default

* Apply suggestions from code review

Co-authored-by: Elena Peña Tapia <[email protected]>

* remove catch

* new deprecate warning message

* lint qiskit/assembler/assemble_circuits.py

* concurrency warnings

* ignore aer warnings

* Update test/python/providers/fake_provider/test_fake_backends.py

Co-authored-by: Elena Peña Tapia <[email protected]>

* Update test/python/circuit/test_parameters.py

Co-authored-by: Elena Peña Tapia <[email protected]>

* Update qiskit/providers/models/pulsedefaults.py

Co-authored-by: Elena Peña Tapia <[email protected]>

* Update test/python/providers/fake_provider/test_fake_backends.py

Co-authored-by: Elena Peña Tapia <[email protected]>

* Update test/python/providers/fake_provider/test_generic_backend_v2.py

Co-authored-by: Elena Peña Tapia <[email protected]>

* lint

* #12649 (comment)

* #12649 (comment)

* Update test/python/transpiler/test_sabre_swap.py

Co-authored-by: Elena Peña Tapia <[email protected]>

* Update qiskit/providers/models/pulsedefaults.py

Co-authored-by: Elena Peña Tapia <[email protected]>

* ignore Treating CircuitInstruction...

* another unnecessary catch from aer

* another unnecessary catch from aer, again

* removing more unnecesary catches

* less lines

* seeding

* remove those comments

* test.python.compiler.test_transpiler.TestTranspile.test_scheduling_timing_constraints

* tokyo cmap

* test.python.circuit.test_scheduled_circuit.TestScheduledCircuit.test_schedule_circuit_when_backend_tells_dt

* comment in test_sequencer.py

* test.python.compiler.test_transpiler.TestPostTranspileIntegration.test_qasm3_output

* Update test/python/primitives/test_primitive.py

Co-authored-by: Elena Peña Tapia <[email protected]>

* test/python/providers/test_backendconfiguration.py:30

* test.python.primitives.test_backend_sampler

* restore the assertWarns, waiting for #12818

* use legacy_cmaps instead of explict coupling maps

* use more legacy_map

* KYOTO_CMAP

* more legacy_cmap

* #12832

---------

Co-authored-by: Elena Peña Tapia <[email protected]>
(cherry picked from commit 7cd2c41)

# Conflicts:
#	test/python/primitives/test_primitive.py
#	test/python/transpiler/test_sabre_layout.py
Copy link
Contributor Author

mergify bot commented Jul 29, 2024

Cherry-pick of 7cd2c41 has failed:

On branch mergify/bp/stable/1.2/pr-12660
Your branch is up to date with 'origin/stable/1.2'.

You are currently cherry-picking commit 7cd2c414b.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   qiskit/providers/fake_provider/fake_backend.py
	modified:   qiskit/providers/fake_provider/generic_backend_v2.py
	modified:   qiskit/visualization/circuit/_utils.py
	modified:   test/python/circuit/test_parameters.py
	modified:   test/python/circuit/test_scheduled_circuit.py
	modified:   test/python/compiler/test_assembler.py
	modified:   test/python/compiler/test_compiler.py
	modified:   test/python/compiler/test_disassembler.py
	modified:   test/python/compiler/test_scheduler.py
	modified:   test/python/compiler/test_sequencer.py
	modified:   test/python/compiler/test_transpiler.py
	modified:   test/python/legacy_cmaps.py
	modified:   test/python/primitives/test_backend_estimator.py
	modified:   test/python/primitives/test_backend_estimator_v2.py
	modified:   test/python/primitives/test_backend_sampler.py
	modified:   test/python/primitives/test_backend_sampler_v2.py
	modified:   test/python/providers/fake_provider/test_fake_backends.py
	modified:   test/python/providers/fake_provider/test_generic_backend_v2.py
	modified:   test/python/providers/test_backend_v2.py
	modified:   test/python/providers/test_backendconfiguration.py
	modified:   test/python/providers/test_backendproperties.py
	modified:   test/python/providers/test_backendstatus.py
	modified:   test/python/providers/test_fake_backends.py
	modified:   test/python/providers/test_pulse_defaults.py
	modified:   test/python/pulse/test_block.py
	modified:   test/python/pulse/test_builder.py
	modified:   test/python/pulse/test_builder_v2.py
	modified:   test/python/pulse/test_instruction_schedule_map.py
	modified:   test/python/pulse/test_macros.py
	modified:   test/python/pulse/test_schedule.py
	modified:   test/python/pulse/test_transforms.py
	modified:   test/python/qpy/test_circuit_load_from_qpy.py
	modified:   test/python/result/test_mitigators.py
	modified:   test/python/scheduler/test_basic_scheduler.py
	modified:   test/python/transpiler/test_1q.py
	modified:   test/python/transpiler/test_calibrationbuilder.py
	modified:   test/python/transpiler/test_echo_rzx_weyl_decomposition.py
	modified:   test/python/transpiler/test_instruction_durations.py
	modified:   test/python/transpiler/test_passmanager_config.py
	modified:   test/python/transpiler/test_passmanager_run.py
	modified:   test/python/transpiler/test_preset_passmanagers.py
	modified:   test/python/transpiler/test_pulse_gate_pass.py
	modified:   test/python/transpiler/test_sabre_swap.py
	modified:   test/python/transpiler/test_star_prerouting.py
	modified:   test/python/transpiler/test_stochastic_swap.py
	modified:   test/python/transpiler/test_target.py
	modified:   test/python/transpiler/test_unitary_synthesis.py
	modified:   test/python/transpiler/test_vf2_layout.py
	modified:   test/python/transpiler/test_vf2_post_layout.py
	modified:   test/python/visualization/test_circuit_drawer.py
	modified:   test/python/visualization/test_circuit_latex.py
	modified:   test/python/visualization/test_gate_map.py

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   test/python/primitives/test_primitive.py
	both modified:   test/python/transpiler/test_sabre_layout.py

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot requested a review from a team as a code owner July 29, 2024 11:11
@mergify mergify bot added the conflicts used by mergify when there are conflicts in a port label Jul 29, 2024
@mergify mergify bot requested review from a team, nonhermitian, eggerdj, wshanks and jyu00 as code owners July 29, 2024 11:11
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the following people are relevant to this code:

  • @enavarro51
  • @Qiskit/terra-core
  • @ajavadia
  • @levbishop
  • @mtreinish
  • @nkanazawa1989
  • @t-imamichi

@github-actions github-actions bot added this to the 1.2.0 milestone Jul 29, 2024
@github-actions github-actions bot added Changelog: Deprecation Include in "Deprecated" section of changelog mod: fake_provider Related to the fake_provider module and fake backends labels Jul 29, 2024
@ElePT ElePT removed the conflicts used by mergify when there are conflicts in a port label Jul 29, 2024
@ElePT ElePT enabled auto-merge July 29, 2024 11:21
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10143269586

Details

  • 5 of 6 (83.33%) changed or added relevant lines in 2 files are covered.
  • 19 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.009%) to 89.946%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit/providers/fake_provider/generic_backend_v2.py 3 4 75.0%
Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 7 91.6%
crates/qasm2/src/parse.rs 12 97.15%
Totals Coverage Status
Change from base Build 10118826632: -0.009%
Covered Lines: 66170
Relevant Lines: 73566

💛 - Coveralls

@ElePT ElePT added this pull request to the merge queue Jul 29, 2024
Merged via the queue into stable/1.2 with commit 04b4d20 Jul 29, 2024
17 checks passed
@mergify mergify bot deleted the mergify/bp/stable/1.2/pr-12660 branch July 29, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Deprecation Include in "Deprecated" section of changelog mod: fake_provider Related to the fake_provider module and fake backends priority: high
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants