-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Incoherent notation for the RZX Gate api doc #12754
Conversation
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the following people are relevant to this code:
|
The default notation for RZX gate was in big-endian and the example shown was in little-endian format. | ||
Fix is done in the example section where the gate notation is concatenated with q_0 , q_1 and | ||
big-endian format is followed throughout. | ||
For example intial notation was : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For example intial notation was : | |
For example initial notation was : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
As side note, I'm not sure this notation of <gate> q0 q1 = <some matrix>
is slightly abusive notation and we might want to fix this at some point (not in this PR!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't typically write release notes for doc fixes, you can just delete this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do. Thanks for the review @Cryoris
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think its fine now. Congrats on your first issue!
@Shivansh20128 the release note is not yet deleted, that's still outstanding 🙂 |
Oh yeah right. Sorry for the oversight. |
Pull Request Test Coverage Report for Build 11124263805Details
💛 - Coveralls |
* Fixed Incoherent notation for the RZX Gate api doc * Delete reno --------- Co-authored-by: Julien Gacon <[email protected]>
* Fixed Incoherent notation for the RZX Gate api doc * Delete reno --------- Co-authored-by: Julien Gacon <[email protected]>
Summary
Fixes #12684
Fixed the issue of notation for the RZX gate. The example section of the api document has been updated and follows the big-endian format. For example now the notation is showed as$R_{ZX}(\theta = 0)\ q_0, q_1 = I$ .