Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GenericBackendV2 should fail when the backend cannot allocate the basis gate because its size (backport #12653) #12667

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 26, 2024

Summary

GenericBackendV2 should not accept backends that are too small for certain gates. The following examples should be rejected:

GenericBackendV2(num_qubits=1, basis_gates=["cx", "id"])

GenericBackendV2(num_qubits=2, basis_gates=["ccx", "id"])

@ElePT found this!


This is an automatic backport of pull request #12653 done by [Mergify](https://mergify.com).

…is gate because its size (#12653)

* GenericBackendV2 should fail when the backend cannot allocate the basis gate because its size

Co-authored-by: Elena Peña Tapia <[email protected]>

* reno

* Update releasenotes/notes/fixes_GenericBackendV2-668e40596e1f070d.yaml

Co-authored-by: Elena Peña Tapia <[email protected]>

* another single qubit backend

---------

Co-authored-by: Elena Peña Tapia <[email protected]>
(cherry picked from commit e36027c)
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@github-actions github-actions bot added the Changelog: Bugfix Include in the "Fixed" section of the changelog label Jun 26, 2024
@coveralls
Copy link

coveralls commented Jun 26, 2024

Pull Request Test Coverage Report for Build 9676645295

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 12 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.02%) to 89.935%

Files with Coverage Reduction New Missed Lines %
qiskit/transpiler/passes/synthesis/unitary_synthesis.py 2 88.2%
crates/qasm2/src/lex.rs 4 92.62%
crates/qasm2/src/parse.rs 6 97.61%
Totals Coverage Status
Change from base Build 9663344566: 0.02%
Covered Lines: 61831
Relevant Lines: 68751

💛 - Coveralls

@ElePT ElePT added this pull request to the merge queue Jun 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 26, 2024
@ElePT ElePT added this pull request to the merge queue Jun 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jun 26, 2024
@1ucian0 1ucian0 added this pull request to the merge queue Jun 26, 2024
Merged via the queue into stable/1.1 with commit 25c0542 Jun 26, 2024
18 checks passed
@mergify mergify bot deleted the mergify/bp/stable/1.1/pr-12653 branch June 26, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants