Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GenericBackendV2 should fail when the backend cannot allocate the basis gate because its size (backport #12653) #12666

Merged
merged 4 commits into from
Jun 26, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 26, 2024

Summary

GenericBackendV2 should not accept backends that are too small for certain gates. The following examples should be rejected:

GenericBackendV2(num_qubits=1, basis_gates=["cx", "id"])

GenericBackendV2(num_qubits=2, basis_gates=["ccx", "id"])

@ElePT found this!


This is an automatic backport of pull request #12653 done by [Mergify](https://mergify.com).

…is gate because its size (#12653)

* GenericBackendV2 should fail when the backend cannot allocate the basis gate because its size

Co-authored-by: Elena Peña Tapia <[email protected]>

* reno

* Update releasenotes/notes/fixes_GenericBackendV2-668e40596e1f070d.yaml

Co-authored-by: Elena Peña Tapia <[email protected]>

* another single qubit backend

---------

Co-authored-by: Elena Peña Tapia <[email protected]>
(cherry picked from commit e36027c)

# Conflicts:
#	qiskit/providers/fake_provider/generic_backend_v2.py
#	test/visual/mpl/graph/test_graph_matplotlib_drawer.py
@mergify mergify bot requested a review from jyu00 as a code owner June 26, 2024 08:57
@mergify mergify bot added the conflicts used by mergify when there are conflicts in a port label Jun 26, 2024
@mergify mergify bot requested a review from a team as a code owner June 26, 2024 08:57
Copy link
Contributor Author

mergify bot commented Jun 26, 2024

Cherry-pick of e36027c has failed:

On branch mergify/bp/stable/0.46/pr-12653
Your branch is up to date with 'origin/stable/0.46'.

You are currently cherry-picking commit e36027c01.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   releasenotes/notes/fixes_GenericBackendV2-668e40596e1f070d.yaml
	modified:   test/python/providers/fake_provider/test_generic_backend_v2.py

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   qiskit/providers/fake_provider/generic_backend_v2.py
	both modified:   test/visual/mpl/graph/test_graph_matplotlib_drawer.py

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@github-actions github-actions bot added the Changelog: Bugfix Include in the "Fixed" section of the changelog label Jun 26, 2024
ElePT
ElePT previously approved these changes Jun 26, 2024
@ElePT ElePT removed the conflicts used by mergify when there are conflicts in a port label Jun 26, 2024
ElePT
ElePT previously approved these changes Jun 26, 2024
@ElePT ElePT enabled auto-merge June 26, 2024 13:27
@coveralls
Copy link

coveralls commented Jun 26, 2024

Pull Request Test Coverage Report for Build 9680536175

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 17 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 87.182%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 5 92.11%
crates/qasm2/src/parse.rs 12 97.15%
Totals Coverage Status
Change from base Build 9665663824: -0.02%
Covered Lines: 74496
Relevant Lines: 85449

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 26, 2024

Pull Request Test Coverage Report for Build 9686312512

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 18 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 87.182%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 6 92.11%
crates/qasm2/src/parse.rs 12 97.15%
Totals Coverage Status
Change from base Build 9665663824: -0.02%
Covered Lines: 74496
Relevant Lines: 85449

💛 - Coveralls

@ElePT ElePT added this pull request to the merge queue Jun 26, 2024
Merged via the queue into stable/0.46 with commit 5def925 Jun 26, 2024
11 checks passed
@mergify mergify bot deleted the mergify/bp/stable/0.46/pr-12653 branch June 26, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants