-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GenericBackendV2 should fail when the backend cannot allocate the basis gate because its size (backport #12653) #12666
Conversation
…is gate because its size (#12653) * GenericBackendV2 should fail when the backend cannot allocate the basis gate because its size Co-authored-by: Elena Peña Tapia <[email protected]> * reno * Update releasenotes/notes/fixes_GenericBackendV2-668e40596e1f070d.yaml Co-authored-by: Elena Peña Tapia <[email protected]> * another single qubit backend --------- Co-authored-by: Elena Peña Tapia <[email protected]> (cherry picked from commit e36027c) # Conflicts: # qiskit/providers/fake_provider/generic_backend_v2.py # test/visual/mpl/graph/test_graph_matplotlib_drawer.py
Cherry-pick of e36027c has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the following people are relevant to this code:
|
Pull Request Test Coverage Report for Build 9680536175Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9686312512Details
💛 - Coveralls |
Summary
GenericBackendV2 should not accept backends that are too small for certain gates. The following examples should be rejected:
GenericBackendV2(num_qubits=1, basis_gates=["cx", "id"])
GenericBackendV2(num_qubits=2, basis_gates=["ccx", "id"])
@ElePT found this!
This is an automatic backport of pull request #12653 done by [Mergify](https://mergify.com).