Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement RGate in Rust #12662

Merged
merged 7 commits into from
Jun 27, 2024
Merged

Implement RGate in Rust #12662

merged 7 commits into from
Jun 27, 2024

Commits on Jun 26, 2024

  1. Implement RGate in Rust

    @jlapeyre
    jlapeyre committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    2a064bd View commit details
    Browse the repository at this point in the history

  2. Update crates/circuit/src/operations.rs 

    Co-authored-by: Elena Peña Tapia <[email protected]>
    @jlapeyre @ElePT
    jlapeyre and ElePT authored Jun 26, 2024
    Configuration menu
    Copy the full SHA
    a034be5 View commit details
    Browse the repository at this point in the history

  3. Fix error in decomposition of RGate 

    There is an error in the expression for decomposition of the R gate
in the port to Rust.

This fixes the error and re-enables the skipped test that failed because
of the incorrect expression.
    @jlapeyre
    jlapeyre committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    7eef0f3 View commit details
    Browse the repository at this point in the history

  4. Factor cloning the Param enum in Rust 

    To clone the enum, each variant must be handled separately.  This is currently used once,
but can be used each time a `Param` is cloned. In case more work needs to be done within
match arms, one might choose not to use this function, but rather clone in each of these
arms.
    @jlapeyre
    jlapeyre committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    49c8dcd View commit details
    Browse the repository at this point in the history

  5. Run cargo fmt

    @jlapeyre
    jlapeyre committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    043133f View commit details
    Browse the repository at this point in the history

  6. Implement and use addition for enum Param 

    This handles `Float` and `ParameterExpression` variants uniformly.
    @jlapeyre
    jlapeyre committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    07fec37 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into implement-r-gate

    @jlapeyre
    jlapeyre authored Jun 26, 2024
    Configuration menu
    Copy the full SHA
    bff9fef View commit details
    Browse the repository at this point in the history