Fix QuantumCircuit.depth with zero-operands and Expr nodes (backport #12429)
#12528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
This causes `QuantumCircuit.depth` to correctly handle cases where a circuit instruction has zero operands (such as `GlobalPhaseGate`), and to treat classical bits and real-time variables used inside `Expr` conditions as part of the depth calculations. This is in line with `DAGCircuit`. This commit still does not add the same `recurse` argument from `DAGCircuit.depth`, because the arguments for not adding it to `QuantumCircuit.depth` at the time still hold; there is no clear meaning to it for general control flow from a user's perspective, and it was only added to the `DAGCircuit` methods because there it is more of a proxy for optimising over all possible inner blocks. (cherry picked from commit d18a74c)
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the following people are relevant to this code:
|
github-actions
bot
added
Changelog: Bugfix
ElePT
approved these changes
Jun 7, 2024
Pull Request Test Coverage Report for Build 9416956394Details
💛 - Coveralls |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This causes
QuantumCircuit.depthto correctly handle cases where a circuit instruction has zero operands (such asGlobalPhaseGate), and to treat classical bits and real-time variables used insideExprconditions as part of the depth calculations. This is in line withDAGCircuit.This commit still does not add the same
recurseargument fromDAGCircuit.depth, because the arguments for not adding it toQuantumCircuit.depthat the time still hold; there is no clear meaning to it for general control flow from a user's perspective, and it was only added to theDAGCircuitmethods because there it is more of a proxy for optimising over all possible inner blocks.Details and comments
Fix #12426.
This is an automatic backport of pull request #12429 done by [Mergify](https://mergify.com).