-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the duplicated docs for a BackendV1
classmethod
#12443
Conversation
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the following people are relevant to this code:
|
Pull Request Test Coverage Report for Build 9158916524Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems right to me thanks, given that it's specified already in the class docs.
(cherry picked from commit 16acb80)
(cherry picked from commit 16acb80) Co-authored-by: Arnau Casau <[email protected]>
The
BackendV1
page has a duplicated entry for the_default_options()
method as we can see in this screenshot highlight it with two red arrows.This PR removes the duplicated autoclass directive for
_default_options()
and the line of documentation explaining that subclasses need to implement it, as it is also explained in line 66.qiskit/qiskit/providers/backend.py
Lines 66 to 69 in a83c99b
With this removal, the docs will match the documentation of
BackendV2
where we use the same explanation once:qiskit/qiskit/providers/backend.py
Lines 316 to 319 in a83c99b
The change will need backport to
stable/1.1
,stable/1.0
, andstable/0.46