-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Oxidize the numeric code in the Isometry gate class #12197
Commits on Apr 17, 2024
-
Oxidize the numeric code in the Isometry gate class
This commit ports the numeric portion of the Isometry gate class to rust. While this will likely improve the performance slightly this move is more to make isolate this code from blas/lapack in numpy. We're hitting some stability issues on arm64 mac in CI and moving this code to rust should hopefully fix this issue. As this is more for functional reasons no real performance tuning was done on this port, there are likely several opportunities to improve the runtime performance of the code.
Configuration menu - View commit details
-
Copy full SHA for 6dca86e - Browse repository at this point
Copy the full SHA 6dca86eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5c21069 - Browse repository at this point
Copy the full SHA 5c21069View commit details -
Configuration menu - View commit details
-
Copy full SHA for cf3c5ff - Browse repository at this point
Copy the full SHA cf3c5ffView commit details -
Oxidize the linalg in UCGate too
The UCGate class is used almost exclusively by the Isometry class to build up the definition of the isometry circuit. There were also some linear algebra inside the function which could also be the source of the stability issues we were seeing on arm64. This commit ports this function as part of the larger isometry migration.
Configuration menu - View commit details
-
Copy full SHA for 8107fb2 - Browse repository at this point
Copy the full SHA 8107fb2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 63e19e3 - Browse repository at this point
Copy the full SHA 63e19e3View commit details -
Configuration menu - View commit details
-
Copy full SHA for b0b7a33 - Browse repository at this point
Copy the full SHA b0b7a33View commit details
Commits on Apr 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for eaf43f0 - Browse repository at this point
Copy the full SHA eaf43f0View commit details
Commits on Apr 19, 2024
-
Remove bitstring usage with bitwise ops
This commit removes the use of bit string manipulations that were faithfully ported from the original python logic (but left a bad taste in my mouth) into more efficient bitwise operations (which were possible in the original python too).
Configuration menu - View commit details
-
Copy full SHA for 23f5e2e - Browse repository at this point
Copy the full SHA 23f5e2eView commit details -
Mostly replace Vec<u8> usage with bitwise operations
The use of intermediate Vec<u8> as proxy bitstrings was originally ported nearly exactly from the python implementation. But since everything is working now this commit switches to use bitwise operations where it makes sense as this will be more efficient.
Configuration menu - View commit details
-
Copy full SHA for cb8fc67 - Browse repository at this point
Copy the full SHA cb8fc67View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b61dcc - Browse repository at this point
Copy the full SHA 7b61dccView commit details
Commits on Apr 26, 2024
-
Apply suggestions from code review
Co-authored-by: Jake Lishman <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6a6f3bc - Browse repository at this point
Copy the full SHA 6a6f3bcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6e86efe - Browse repository at this point
Copy the full SHA 6e86efeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3676469 - Browse repository at this point
Copy the full SHA 3676469View commit details -
Configuration menu - View commit details
-
Copy full SHA for 29ffc99 - Browse repository at this point
Copy the full SHA 29ffc99View commit details -
Configuration menu - View commit details
-
Copy full SHA for 366a934 - Browse repository at this point
Copy the full SHA 366a934View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4843ef5 - Browse repository at this point
Copy the full SHA 4843ef5View commit details -
Configuration menu - View commit details
-
Copy full SHA for d26bd4a - Browse repository at this point
Copy the full SHA d26bd4aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 091d229 - Browse repository at this point
Copy the full SHA 091d229View commit details -
Configuration menu - View commit details
-
Copy full SHA for d540511 - Browse repository at this point
Copy the full SHA d540511View commit details -
Configuration menu - View commit details
-
Copy full SHA for 604e33a - Browse repository at this point
Copy the full SHA 604e33aView commit details
Commits on Apr 29, 2024
-
Update crates/accelerate/src/isometry.rs
Co-authored-by: John Lapeyre <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3bd4358 - Browse repository at this point
Copy the full SHA 3bd4358View commit details -
Configuration menu - View commit details
-
Copy full SHA for c04aa17 - Browse repository at this point
Copy the full SHA c04aa17View commit details -
Configuration menu - View commit details
-
Copy full SHA for b8b82a6 - Browse repository at this point
Copy the full SHA b8b82a6View commit details
Commits on Apr 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for fcf587f - Browse repository at this point
Copy the full SHA fcf587fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2c07b79 - Browse repository at this point
Copy the full SHA 2c07b79View commit details