Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bad indentation on quantumcircuit.py #11744

Merged
merged 3 commits into from
Feb 12, 2024
Merged

Fix bad indentation on quantumcircuit.py #11744

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
65e6284
fix indentation quantumcircuit.py
arnaucasau Feb 7, 2024
0a590fd
Merge branch 'main' into AC/fix-bad-indentation
arnaucasau Feb 8, 2024
39bf7f4
Merge branch 'main' into AC/fix-bad-indentation
Eric-Arellano Feb 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions qiskit/circuit/quantumcircuit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2526,17 +2526,17 @@ def parameters(self) -> ParameterView:

.. code-block:: python

>>> from qiskit.circuit import QuantumCircuit, Parameter, ParameterVector
>>> x = ParameterVector("x", 12)
>>> circuit = QuantumCircuit(1)
>>> for x_i in x:
... circuit.rx(x_i, 0)
>>> circuit.parameters
ParameterView([
ParameterVectorElement(x[0]), ParameterVectorElement(x[1]),
ParameterVectorElement(x[2]), ParameterVectorElement(x[3]),
..., ParameterVectorElement(x[11])
])
>>> from qiskit.circuit import QuantumCircuit, Parameter, ParameterVector
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the >>> here? It always seemed unnecessary to put that in there and it gets in the way of copy and paste.

Copy link
Contributor Author

@arnaucasau arnaucasau Feb 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in this case is useful to differentiate the instructions from the final output (shows the value of circuit.parameters as you would show it on jupyter-notebook rather than printing it like in the other code-block).

The good thing here is that you can't select the >>> part, so it shouldn't get in the way of copy and paste :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with leaving this like this as this is just fixing a clear spacing issue. I still think we might want to revisit >>> usage in the future more broadly, but there isn't any reason to block this over that as it's a good fix.

>>> x = ParameterVector("x", 12)
>>> circuit = QuantumCircuit(1)
>>> for x_i in x:
... circuit.rx(x_i, 0)
>>> circuit.parameters
ParameterView([
ParameterVectorElement(x[0]), ParameterVectorElement(x[1]),
ParameterVectorElement(x[2]), ParameterVectorElement(x[3]),
..., ParameterVectorElement(x[11])
])


Returns:
Expand Down Expand Up @@ -3991,12 +3991,12 @@ def prepare_state(

.. code-block::

import numpy as np
from qiskit import QuantumCircuit
import numpy as np
from qiskit import QuantumCircuit

circuit = QuantumCircuit(1)
circuit.prepare_state([1/np.sqrt(2), -1/np.sqrt(2)], 0)
circuit.draw()
circuit = QuantumCircuit(1)
circuit.prepare_state([1/np.sqrt(2), -1/np.sqrt(2)], 0)
circuit.draw()

output:

Expand Down
Loading