-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use pulse_alignment from Target in PadDynamicalDecoupling #11660
Conversation
One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 7726869440
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the proposed fix, if the user provides both pulse_alignment
and target
, the pulse_alignment
argument will be ignored (the same was and is true for the durations
argument). I think this is counter intuitive and should be reflected to the user somehow.
Yeah, I agree this should update the docstring to reflect that |
I updated the docstring to make this clear. I believe this is the behavior across the board (in all passes target takes precedence). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the docstring too. I agree this is consistent with how target is handled in other passes too
Summary
The intent for the Target argument in transpiler passes is that they will supply the necessary information for passes to use. There was an oversight when adding this for the PadDynamicalDecoupling pass, where users still had to separately pass
pulse_alignment
even though this information is contained in the Target. This commit is a simple fix of that oversight.Details and comments