Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use pulse_alignment from Target in PadDynamicalDecoupling #11660

Merged
merged 2 commits into from
Jan 31, 2024

Conversation

ajavadia
Copy link
Member

Summary

The intent for the Target argument in transpiler passes is that they will supply the necessary information for passes to use. There was an oversight when adding this for the PadDynamicalDecoupling pass, where users still had to separately pass pulse_alignment even though this information is contained in the Target. This commit is a simple fix of that oversight.

Details and comments

@ajavadia ajavadia requested a review from a team as a code owner January 29, 2024 02:37
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@ajavadia ajavadia added this to the 1.0.0 milestone Jan 29, 2024
@coveralls
Copy link

coveralls commented Jan 29, 2024

Pull Request Test Coverage Report for Build 7726869440

  • 0 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 13 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.004%) to 89.548%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/expr.rs 1 93.81%
crates/qasm2/src/lex.rs 6 91.44%
crates/qasm2/src/parse.rs 6 97.62%
Totals Coverage Status
Change from base Build 7674621352: -0.004%
Covered Lines: 59586
Relevant Lines: 66541

💛 - Coveralls

Copy link
Collaborator

@TsafrirA TsafrirA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the proposed fix, if the user provides both pulse_alignment and target, the pulse_alignment argument will be ignored (the same was and is true for the durations argument). I think this is counter intuitive and should be reflected to the user somehow.

@mtreinish
Copy link
Member

Yeah, I agree this should update the docstring to reflect that target will supersede pulse_alignment if set (like it currently does for the other arguments).

@ajavadia
Copy link
Member Author

I updated the docstring to make this clear. I believe this is the behavior across the board (in all passes target takes precedence).

Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the docstring too. I agree this is consistent with how target is handled in other passes too

@mtreinish mtreinish added the Changelog: Bugfix Include in the "Fixed" section of the changelog label Jan 31, 2024
@mtreinish mtreinish added this pull request to the merge queue Jan 31, 2024
Merged via the queue into main with commit 0407e64 Jan 31, 2024
14 checks passed
@jakelishman jakelishman deleted the dd-alignment-from-target branch January 31, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants