Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove deprecated aquire alignment #11553

Merged
merged 3 commits into from
Jan 12, 2024
Merged

remove deprecated aquire alignment #11553

merged 3 commits into from
Jan 12, 2024

Conversation

ewinston
Copy link
Contributor

Summary

This removes deprecated method "aquire_alignment".

Details and comments

@ewinston ewinston requested a review from a team as a code owner January 12, 2024 18:42
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@coveralls
Copy link

coveralls commented Jan 12, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 7507318797

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.009%) to 89.348%
Totals Coverage Status
Change from base Build 7504893879: 0.009%
Covered Lines: 59529
Relevant Lines: 66626
💛 - Coveralls

mtreinish
mtreinish reviewed Jan 12, 2024
View reviewed changes
Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just needs a small fix to remove the unused import to address the lint failure

@mtreinish mtreinish added this pull request to the merge queue Jan 12, 2024
@jakelishman jakelishman added the Changelog: Removal Include in the Removed section of the changelog label Jan 12, 2024
@jakelishman jakelishman added this to the 1.0.0 milestone Jan 12, 2024
Merged via the queue into Qiskit:main with commit fc567f0 Jan 12, 2024
13 checks passed
ShellyGarion pushed a commit to ShellyGarion/qiskit-terra that referenced this pull request Jan 18, 2024
@ewinston @ShellyGarion
remove deprecated aquire alignment (Qiskit#11553)
206415b 
* remove deprecated "aquire_alignment"

* added release notes

* linting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtreinish mtreinish mtreinish approved these changes

Assignees
No one assigned
Labels
Changelog: Removal Include in the Removed section of the changelog
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ewinston @qiskit-bot @coveralls @mtreinish @jakelishman