Removed Deprecated VF2 Call Limit #11540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbrandhsn
added
the
Changelog: Removal
|
One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 7482563209
💛 - Coveralls |
releasenotes/notes/deprecation-passmanager-0.25-95eb9b45b517370a.yaml
Outdated
Show resolved
Hide resolved
kevinhartman
approved these changes
Jan 11, 2024
| upgrade: | ||
| - | | ||
| Removed deprecated function :func:`~qiskit.transpiler.preset_passmanagers.common.get_vf2_call_limit` | ||
| and its corresponding test. Instead, use |
There was a problem hiding this comment.
One more small point for release note style is that we ought to only mention user-facing changes, so in this case we can omit the bit about the tests being updated. Not a reason to hold up this PR, we can easily adjust this when we create and review the release notes PR during release 🙂.
There was a problem hiding this comment.
Sounds good, I will keep this in mind the next time I write a release note, thanks! :-)
ShellyGarion
pushed a commit
to ShellyGarion/qiskit-terra
that referenced
this pull request
Jan 18, 2024
* deprecate 0.25 passmanager * revert * removed deprecated function get_vf2_call_limit * minor: lint/black * reno fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removed deprecated
get_vf2_call_limitfunction and associated tests.Details and comments