Removed Deprecated Instruction.qasm Function #11538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbrandhsn
added
the
Changelog: Removal
|
One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 7503642573Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
jakelishman
reviewed
Jan 12, 2024
Comment on lines
294
to
298
| def qasm(self): | ||
| """ | ||
| Raise an error when trying to convert a placeholder instruction to OpenQASM 2 | ||
| """ | ||
| raise CircuitError("Cannot convert a placeholder instruction to OpenQASM 2") |
There was a problem hiding this comment.
This whole function wants removing as well - it's just an override of Instruction.qasm to catch internal logic errors. It's not decorated as "deprecated" because instances of these classes should never be accessible publicly.
There was a problem hiding this comment.
Sounds good to me, I removed the qasm method. Thanks for reviewing! :-)
releasenotes/notes/deprecate-circuit-qasm-e5bbad027388e3f2.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Jake Lishman <[email protected]>
jakelishman
approved these changes
Jan 12, 2024
ShellyGarion
pushed a commit
to ShellyGarion/qiskit-terra
that referenced
this pull request
Jan 18, 2024
* removed deprecated circuit.qasm function * reno... * reno. * reno right location * weird lint behavior * lint fix... * updated release note * update release note Co-authored-by: Jake Lishman <[email protected]> * Update builder.py --------- Co-authored-by: Jake Lishman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removed the
Instruction.qasmfunction and removed or changed the associated test cases to use qasm2.dumpDetails and comments