Deprecate qiskit/transpiler/synthesis and move to qiskit/synthesis #11426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShellyGarion
added
the
Changelog: Deprecation
|
One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 7614139856Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
ShellyGarion
changed the title
|
Like the deprecation of |
ShellyGarion
changed the title
Cryoris
reviewed
Jan 22, 2024
qiskit/synthesis/__init__.py
Outdated
| Unitary Synthesis | ||
| ================= | ||
|
|
||
| The Approximate Quantum Compiler is available here: :mod:qiskit.synthesis.unitary.aqc |
There was a problem hiding this comment.
Suggested change
| The Approximate Quantum Compiler is available here: :mod:qiskit.synthesis.unitary.aqc | |
| The Approximate Quantum Compiler is available here: :mod:`qiskit.synthesis.unitary.aqc` |
There was a problem hiding this comment.
Currently the AQC docs live under the builtin transpiler plugins as only object. Would it make sense to put them with the Solovay Kitaev docs? I also don't quite understand the "builtin transpiler plugin" page, aren't there a lot more builtin plugins than AQC?
There was a problem hiding this comment.
@Cryoris - thanks for the detailed review!
I think that the AQCSynthesisPlugin also appears now with the other synthesis plugins here:
https://docs.quantum.ibm.com/api/qiskit/transpiler_passes#synthesis
Cryoris
added
the
stable backport potential
Cryoris
approved these changes
Jan 23, 2024
mergify bot
pushed a commit
that referenced
this pull request
Jan 23, 2024
…11426) * deprecate transpiler/synthesis/graysynth.py * style * style * move aqc_plugin to qiskit/transpiler/passes/synthesis * remove code from qiskit/transpiler/synthesis/aqc/aqc_plugin.py * copy qiskit/transpiler/synthesis/aqc to qiskit/synthesis/unitary * move tests from test/python/transpiler/aqc to test/python/synthesis/aqc * update imports in aqc_plugin * add deprecation warning to AQC module * handle cyclic imports * handle cyclic imports * update link in docs * update init in qiskit/transpiler/synthesis/aqc * style * temporary remove deprecation warning test * remove files from qiskit/transpiler/synthesis/aqc * update link in test * add release notes * update docs * update docs/apidocs/synthesis_aqc.rst * add deprecations to qiskit/transpiler/synthesis/__init__.py * fix link * improve docs following review * update docs * add aqc to synthesis docs after review * update qiskit/transpiler/synthesis/aqc/__init__.py after review * update pending deprecation to deprecation in release notes * handle cyclic imports * update qiskit/synthesis docs following docs error * another attempt to add AQC to synthesis docs * another attempt to add AQC to the docs * Revert "another attempt to add AQC to the docs" This reverts commit 25f93ca. * Revert "another attempt to add AQC to synthesis docs" This reverts commit 9e87164. * add a deprecation test for AQC * minor (cherry picked from commit 937ca5b) # Conflicts: # pyproject.toml # qiskit/synthesis/__init__.py # qiskit/transpiler/passes/synthesis/aqc_plugin.py
Cryoris
added a commit
to Cryoris/qiskit-terra
that referenced
this pull request
Jan 23, 2024
Cryoris
added a commit
to Cryoris/qiskit-terra
that referenced
this pull request
Jan 23, 2024
…iskit#11426) * deprecate transpiler/synthesis/graysynth.py * style * style * move aqc_plugin to qiskit/transpiler/passes/synthesis * remove code from qiskit/transpiler/synthesis/aqc/aqc_plugin.py * copy qiskit/transpiler/synthesis/aqc to qiskit/synthesis/unitary * move tests from test/python/transpiler/aqc to test/python/synthesis/aqc * update imports in aqc_plugin * add deprecation warning to AQC module * handle cyclic imports * handle cyclic imports * update link in docs * update init in qiskit/transpiler/synthesis/aqc * style * temporary remove deprecation warning test * remove files from qiskit/transpiler/synthesis/aqc * update link in test * add release notes * update docs * update docs/apidocs/synthesis_aqc.rst * add deprecations to qiskit/transpiler/synthesis/__init__.py * fix link * improve docs following review * update docs * add aqc to synthesis docs after review * update qiskit/transpiler/synthesis/aqc/__init__.py after review * update pending deprecation to deprecation in release notes * handle cyclic imports * update qiskit/synthesis docs following docs error * another attempt to add AQC to synthesis docs * another attempt to add AQC to the docs * Revert "another attempt to add AQC to the docs" This reverts commit 25f93ca. * Revert "another attempt to add AQC to synthesis docs" This reverts commit 9e87164. * add a deprecation test for AQC * minor
Cryoris
added a commit
to Cryoris/qiskit-terra
that referenced
this pull request
Jan 23, 2024
…iskit#11426) * deprecate transpiler/synthesis/graysynth.py * style * style * move aqc_plugin to qiskit/transpiler/passes/synthesis * remove code from qiskit/transpiler/synthesis/aqc/aqc_plugin.py * copy qiskit/transpiler/synthesis/aqc to qiskit/synthesis/unitary * move tests from test/python/transpiler/aqc to test/python/synthesis/aqc * update imports in aqc_plugin * add deprecation warning to AQC module * handle cyclic imports * handle cyclic imports * update link in docs * update init in qiskit/transpiler/synthesis/aqc * style * temporary remove deprecation warning test * remove files from qiskit/transpiler/synthesis/aqc * update link in test * add release notes * update docs * update docs/apidocs/synthesis_aqc.rst * add deprecations to qiskit/transpiler/synthesis/__init__.py * fix link * improve docs following review * update docs * add aqc to synthesis docs after review * update qiskit/transpiler/synthesis/aqc/__init__.py after review * update pending deprecation to deprecation in release notes * handle cyclic imports * update qiskit/synthesis docs following docs error * another attempt to add AQC to synthesis docs * another attempt to add AQC to the docs * Revert "another attempt to add AQC to the docs" This reverts commit 25f93ca. * Revert "another attempt to add AQC to synthesis docs" This reverts commit 9e87164. * add a deprecation test for AQC * minor Co-authored-by: Shelly Garion <[email protected]>
Cryoris
removed
the
stable backport potential
|
@Mergifyio backport stable/0.46 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jan 23, 2024
…11426) * deprecate transpiler/synthesis/graysynth.py * style * style * move aqc_plugin to qiskit/transpiler/passes/synthesis * remove code from qiskit/transpiler/synthesis/aqc/aqc_plugin.py * copy qiskit/transpiler/synthesis/aqc to qiskit/synthesis/unitary * move tests from test/python/transpiler/aqc to test/python/synthesis/aqc * update imports in aqc_plugin * add deprecation warning to AQC module * handle cyclic imports * handle cyclic imports * update link in docs * update init in qiskit/transpiler/synthesis/aqc * style * temporary remove deprecation warning test * remove files from qiskit/transpiler/synthesis/aqc * update link in test * add release notes * update docs * update docs/apidocs/synthesis_aqc.rst * add deprecations to qiskit/transpiler/synthesis/__init__.py * fix link * improve docs following review * update docs * add aqc to synthesis docs after review * update qiskit/transpiler/synthesis/aqc/__init__.py after review * update pending deprecation to deprecation in release notes * handle cyclic imports * update qiskit/synthesis docs following docs error * another attempt to add AQC to synthesis docs * another attempt to add AQC to the docs * Revert "another attempt to add AQC to the docs" This reverts commit 25f93ca. * Revert "another attempt to add AQC to synthesis docs" This reverts commit 9e87164. * add a deprecation test for AQC * minor (cherry picked from commit 937ca5b) # Conflicts: # pyproject.toml # qiskit/synthesis/__init__.py # qiskit/transpiler/passes/synthesis/aqc_plugin.py
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 24, 2024
…ackport #11426) (#11624) * Deprecate qiskit/transpiler/synthesis and move to qiskit/synthesis (#11426) * deprecate transpiler/synthesis/graysynth.py * style * style * move aqc_plugin to qiskit/transpiler/passes/synthesis * remove code from qiskit/transpiler/synthesis/aqc/aqc_plugin.py * copy qiskit/transpiler/synthesis/aqc to qiskit/synthesis/unitary * move tests from test/python/transpiler/aqc to test/python/synthesis/aqc * update imports in aqc_plugin * add deprecation warning to AQC module * handle cyclic imports * handle cyclic imports * update link in docs * update init in qiskit/transpiler/synthesis/aqc * style * temporary remove deprecation warning test * remove files from qiskit/transpiler/synthesis/aqc * update link in test * add release notes * update docs * update docs/apidocs/synthesis_aqc.rst * add deprecations to qiskit/transpiler/synthesis/__init__.py * fix link * improve docs following review * update docs * add aqc to synthesis docs after review * update qiskit/transpiler/synthesis/aqc/__init__.py after review * update pending deprecation to deprecation in release notes * handle cyclic imports * update qiskit/synthesis docs following docs error * another attempt to add AQC to synthesis docs * another attempt to add AQC to the docs * Revert "another attempt to add AQC to the docs" This reverts commit 25f93ca. * Revert "another attempt to add AQC to synthesis docs" This reverts commit 9e87164. * add a deprecation test for AQC * minor (cherry picked from commit 937ca5b) # Conflicts: # pyproject.toml # qiskit/synthesis/__init__.py # qiskit/transpiler/passes/synthesis/aqc_plugin.py * Fix merge conflicts * add pylint disable cyclic import * remove Optimizer from aqc * Revert "remove Optimizer from aqc" This reverts commit 63d1ca2. * handle cyclic imoports in AQC * fix plugin entry point --------- Co-authored-by: Shelly Garion <[email protected]> Co-authored-by: Julien Gacon <[email protected]> Co-authored-by: Shelly Garion <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
co-authored by @prakharb10
This PR replaces PR #11079 of @prakharb10 which was not completed.
Deprecate
qiskit/transpiler/synthesisand move files toqiskit/synthesisqiskit/transpiler/synthesis/aqcmoved toqiskit/synthesis/unitary/aqc(except ofaqc_plugin)qiskit/transpiler/synthesis/aqc/aqc_pluginmoved toqiskit/transpiler/passes/synthesisqiskit/transpiler/synthesis/graysynthmoved toqiskit/synthesis/linear_phase/synth_cnot_phase_aamqiskit/transpiler/synthesis/cnot_synthmoved toqiskit/synthesis/linear/synth_cnot_count_full_pmhDetails and comments
Close #10819
Also partly handles the following issues:
#4311
#4699
#9667
#7986