Fix QuantumCircuit.barrier argument conversion
#11272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The manual argument conversion within `QuantumCircuit.barrier` made it inconsistent with the rest of the circuit methods, and it would silently generate invalid circuit output when given iterables outside an expected set. This switches the method to use the standard argument conversion, bringing it inline with the rest of the circuit methods.
jakelishman
added
stable backport potential
|
One or more of the the following people are requested to review this:
|
mtreinish
previously approved these changes
Nov 17, 2023
Co-authored-by: Matthew Treinish <[email protected]>
Pull Request Test Coverage Report for Build 6909575184
💛 - Coveralls |
mtreinish
approved these changes
Nov 17, 2023
mergify bot
pushed a commit
that referenced
this pull request
Nov 18, 2023
* Fix `QuantumCircuit.barrier` argument conversion The manual argument conversion within `QuantumCircuit.barrier` made it inconsistent with the rest of the circuit methods, and it would silently generate invalid circuit output when given iterables outside an expected set. This switches the method to use the standard argument conversion, bringing it inline with the rest of the circuit methods. * Include link to issue Co-authored-by: Matthew Treinish <[email protected]> --------- Co-authored-by: Matthew Treinish <[email protected]> (cherry picked from commit 252dbd5)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 18, 2023
* Fix `QuantumCircuit.barrier` argument conversion The manual argument conversion within `QuantumCircuit.barrier` made it inconsistent with the rest of the circuit methods, and it would silently generate invalid circuit output when given iterables outside an expected set. This switches the method to use the standard argument conversion, bringing it inline with the rest of the circuit methods. * Include link to issue Co-authored-by: Matthew Treinish <[email protected]> --------- Co-authored-by: Matthew Treinish <[email protected]> (cherry picked from commit 252dbd5) Co-authored-by: Jake Lishman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The manual argument conversion within
QuantumCircuit.barriermade it inconsistent with the rest of the circuit methods, and it would silently generate invalid circuit output when given iterables outside an expected set. This switches the method to use the standard argument conversion, bringing it inline with the rest of the circuit methods.Details and comments
Fix #11208.