Add missing atol argument to floating-point test
#10439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The other assertion in this test has the `atol` parameter, but this one is missing it, which can occasionally lead to off-by-one-bit differences in the complex multiplication outputs.
jakelishman
added
type: qa
|
One or more of the the following people are requested to review this:
|
1 task
Pull Request Test Coverage Report for Build 5577280832
💛 - Coveralls |
mtreinish
approved these changes
Jul 17, 2023
mergify bot
pushed a commit
that referenced
this pull request
Jul 17, 2023
The other assertion in this test has the `atol` parameter, but this one is missing it, which can occasionally lead to off-by-one-bit differences in the complex multiplication outputs. (cherry picked from commit fafb750)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 17, 2023
The other assertion in this test has the `atol` parameter, but this one is missing it, which can occasionally lead to off-by-one-bit differences in the complex multiplication outputs. (cherry picked from commit fafb750) Co-authored-by: Jake Lishman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The other assertion in this test has the
atolparameter, but this one is missing it, which can occasionally lead to off-by-one-bit differences in the complex multiplication outputs.Details and comments
The test
test.python.quantum_info.operators.symplectic.test_sparse_pauli_op.TestSparsePauliOpMethods.test_mulhas been flaky in CI since #10264, due to a pre-existing missingatolparameter.