Add Expr support to DAGCircuit.replace_block_with_node
#10383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakelishman
added
the
Changelog: New Feature
|
One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 5604249573
💛 - Coveralls |
Control-flow operations might not include their classical resources in their `cargs` fields while in the `DAGCircuit` form (since the resources have no particular order, and are inherent to the operation), so we needed to update the logic of the `wire_pos_map` sorter to have a way to specify that some bits need not be present in the output.
jakelishman
force-pushed
the
expr/dag-replace-block
branch
from
9fea695
to
fce324c
Compare
|
Rebased on |
to24toro
pushed a commit
to to24toro/qiskit-terra
that referenced
this pull request
Aug 3, 2023
) Control-flow operations might not include their classical resources in their `cargs` fields while in the `DAGCircuit` form (since the resources have no particular order, and are inherent to the operation), so we needed to update the logic of the `wire_pos_map` sorter to have a way to specify that some bits need not be present in the output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Control-flow operations might not include their classical resources in their
cargsfields while in theDAGCircuitform (since the resources have no particular order, and are inherent to the operation), so we needed to update the logic of thewire_pos_mapsorter to have a way to specify that some bits need not be present in the output.Details and comments
Close #10231. Depends on #10377.